WebUSB: use compute_from #1964
Merged
WebUSB: use compute_from #1964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
captainbrosset
approved these changes
Oct 14, 2024
Elchi3
force-pushed
the
webusb-compute-from
branch
from
c25c739 to
5ac780f
Compare
ddbeck
approved these changes
Oct 15, 2024
Collaborator
|
Thank you! And yes, I think #841 is answered by compute_from and per-key statuses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and delete the draft files.
Not sure if y'all still want to implement #841 but I think many other features used
compute_fromin this case.(I think #842 predates compute_from)