Adds display: contents #1966
Merged
Adds display: contents #1966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
vwallen
commented
Oct 14, 2024
Contributor
Author
|
@captainbrosset I saw your comment on the other PR (#1131). How does this look to you? |
captainbrosset
previously requested changes
Oct 15, 2024
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>
ddbeck
requested changes
Oct 28, 2024
Collaborator
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
I've made some suggestions to handle the accessibility issue. This is still blocked until the next BCD release, even if these suggestions are resolved.
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Collaborator
|
@vwallen I just merged the latest BCD, so |
ddbeck
approved these changes
Nov 1, 2024
vwallen
added a commit
to oddbird/web-features
that referenced
this pull request
Nov 5, 2024
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com> Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would replace an existing draft PR that appears inactive: #1131
The support story here is messy: BCD shows high support, but Can I Use shows partial support across the board due to buggy implementations or significant accessibility problems (for example, removing
<button>elements from focus navigation).The
css.properties.display.contents.contents_unusualrefers to default behavior for elements wheredisplay: contentswould result in incomplete, non-semantic, or non-nonsensical behavior. This part of the spec doesn't provide any guidance as to how this should affect accessibility.Closes #1131.