Skip to content

Add keys from BCD 5.6.6 release to existing features #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 28, 2024
Merged

Add keys from BCD 5.6.6 release to existing features #1972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
20c3a90
Add keys added in BCD 5.6.6
jamesnw Oct 14, 2024
202d428
Merge branch 'main' of github.com:web-platform-dx/web-features into n…
jamesnw Oct 15, 2024
45d3489
Update dists, compute from
jamesnw Oct 15, 2024
1d36a73
Update draft
jamesnw Oct 15, 2024
5ef8010
Update dist
jamesnw Oct 15, 2024
a5db662
Merge branch 'main' of github.com:web-platform-dx/web-features into n…
jamesnw Oct 17, 2024
333358e
Update dist
jamesnw Oct 17, 2024
d4eb1ed
Merge branch 'main' of github.com:web-platform-dx/web-features into n…
jamesnw Oct 18, 2024
12a6639
Review
jamesnw Oct 18, 2024
1a70b23
Merge branch 'main' of github.com:web-platform-dx/web-features into n…
jamesnw Oct 21, 2024
e95bb19
Undo changes, add comment
jamesnw Oct 21, 2024
217baf6
Undo draft changes
jamesnw Oct 21, 2024
fa1dc18
Spec cleanup
jamesnw Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions features/multi-column.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ compat_features:
- css.properties.column-count
- css.properties.column-count.auto
- css.properties.column-width
- css.properties.column-width.auto
- css.properties.columns
- css.properties.column-gap
- css.properties.column-gap.multicol_context
Expand Down
13 changes: 13 additions & 0 deletions features/multi-column.yml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,19 @@ compat_features:
# safari_ios: "10"
- css.properties.column-gap.multicol_context

# baseline: high
# baseline_low_date: 2020-01-15
# baseline_high_date: 2022-07-15
# support:
# chrome: "50"
# chrome_android: "50"
# edge: "79"
# firefox: "50"
# firefox_android: "50"
# safari: "9"
# safari_ios: "9"
- css.properties.column-width.auto
Comment on lines +76 to +87
Copy link
Contributor

@captainbrosset captainbrosset Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused here. The browser versions for the auto value on MDN doesn't match what we have here:
image

Checking BCD confirms what's on MDN:
image

Any idea why our code returns these older browser versions for this key?

Copy link
Collaborator Author

@jamesnw jamesnw Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused here. The browser versions for the auto value on MDN doesn't match what we have here:

Interesting. It looks like column-width was prefixed in Chrome until version 50, and compute-baseline is able to pick up that the auto keyword would have been only usable with a prefixed property. So I think what is in the dist here is correct, but I'm not sure if BCD needs an update of some sort.

Copy link
Collaborator

@ddbeck ddbeck Oct 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right. compute-baseline checks ancestor compat features (we turned this on in #1485). This is an oddity of BCD's data model. It can't directly express the idea that a feature is, for example, behind a prefix when some parent of that feature is behind a prefix.


# baseline: false
# support:
# chrome: "66"
Expand Down
2 changes: 2 additions & 0 deletions features/object-position.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@ spec: https://drafts.csswg.org/css-images-3/#the-object-position
# `caniuse: object-fit` is set in object-fit.yml
compat_features:
- css.properties.object-position
# TODO: Compat data is unclear on which elements are supported, and needs to be resolved upstream in https://github.com/mdn/browser-compat-data/issues/23586.
# css.properties.object-position.applies_to_iframe_elements
4 changes: 4 additions & 0 deletions features/white-space-collapse.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@ name: white-space-collapse
description: The `white-space-collapse` CSS property sets whether new line characters are shown as line breaks, and whether multiple consecutive spaces are all displayed or combined.
spec: https://drafts.csswg.org/css-text-4/#white-space-collapsing
group: white-space
# Computing status to ignore preserve-spaces which is experimental and may change.
status:
compute_from: css.properties.white-space-collapse
compat_features:
- css.properties.white-space-collapse
- css.properties.white-space-collapse.break-spaces
- css.properties.white-space-collapse.collapse
- css.properties.white-space-collapse.preserve
- css.properties.white-space-collapse.preserve-breaks
- css.properties.white-space-collapse.preserve-spaces
17 changes: 17 additions & 0 deletions features/white-space-collapse.yml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,25 @@ status:
safari: "17.4"
safari_ios: "17.4"
compat_features:
# ⬇️ Same status as overall feature ⬇️
# baseline: low
# baseline_low_date: 2024-03-19
# support:
# chrome: "114"
# chrome_android: "114"
# edge: "114"
# firefox: "124"
# firefox_android: "124"
# safari: "17.4"
# safari_ios: "17.4"
- css.properties.white-space-collapse
- css.properties.white-space-collapse.break-spaces
- css.properties.white-space-collapse.collapse
- css.properties.white-space-collapse.preserve
- css.properties.white-space-collapse.preserve-breaks

# baseline: false
# support:
# firefox: "124"
# firefox_android: "124"
- css.properties.white-space-collapse.preserve-spaces