Adds host scoping pseudo-element #1974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
vwallen
commented
Oct 15, 2024
features/host.yml
Outdated
| @@ -0,0 +1,10 @@ | |||
| name: Host | |||
| description: The `::host` CSS pseudo-element selects the containing element of the shadow tree in which it is used. | |||
Contributor
Author
There was a problem hiding this comment.
Unclear if the description should be extended to include ::host() and ::host-context() explicitly. I left them off for brevity
Collaborator
There was a problem hiding this comment.
I think :host-context() should be a separate feature, based on support, and :host() should be mentioned in the description here.
jamesnw
requested changes
Oct 16, 2024
features/host.yml
Outdated
| @@ -0,0 +1,10 @@ | |||
| name: Host | |||
| description: The `::host` CSS pseudo-element selects the containing element of the shadow tree in which it is used. | |||
Collaborator
There was a problem hiding this comment.
I think :host-context() should be a separate feature, based on support, and :host() should be mentioned in the description here.
Co-authored-by: James Stuckey Weber <jamesnw@gmail.com>
jamesnw
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.