-
Notifications
You must be signed in to change notification settings - Fork 199
Add WebGL extensions #2072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebGL extensions #2072
Conversation
|
@ddbeck are you okay with the "The And for the name, I now have "WebGL OES_texture_float extension". I'm assuming you would rather like "OES_texture_float WebGL extension"? |
|
Yeah, I think that looks good.
Yes, please! Though I imagine "OES_texture_float" or "EXT_color_buffer_half_float" is sufficiently unique by itself. To embellish on the descriptions a little, I'd write the template like this:
This would also be fine:
Though I expect that's a best case scenario. I won't be bothered to see some "extension represents a…" or "is a…". The audience for this is pretty niche and I won't lose sleep over some basic descriptions, if it's obvious when someone who doesn't know anything about WebGL realizes they're not the audience for this information. 😄 |
|
Thanks Daniel. This is now ready to review and d144915 might help for taking a look at names and descriptions specifically. |
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I think this is ready to go. A few comments cleaning up the descriptions here. Please accept what you like, modify (or ignore) what you don't, and merge it. Thank you!
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
#1583 decided to put some WebGL extensions in the main WebGL feature but not all of them. I think no WebGL extension should be with the main WebGL feature. The extensions have very different support, some are meant to be for certain operating systems only (mobile only, for example), some require specific drivers, etc. I think it is best if they stand on their own. I introduced a "webgl-extensions" group to keep them together.
Still to be done are the descriptions, but would be nice to get a 👍 on the approach here before writing all of them.