Add CSSImportRule.supportsText key to @supports #2095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
ddbeck
approved these changes
Oct 28, 2024
vwallen
pushed a commit
to oddbird/web-features
that referenced
this pull request
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linked issue says to sort this out on the long tail, which I think we're at.
#1353 (comment)
Essentially,
api.CSSImportRule.supportsTexthas some data issues, but does not impact baseline.In looking into it, Chrome and Firefox data is correct. In both, the CSSOM portions were shipped first. In Chrome, that was accidental, and in Firefox, it was behind a flag in 114, but the CSSOM was still accessible.
For Safari, it looks like
css.at-rules.import.supportsshould also be marked as 17.5. I opened mdn/browser-compat-data#24842. I don't think this change needs to be blocked on that.