-
Notifications
You must be signed in to change notification settings - Fork 199
Add additional overflow keys #2102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
features/overflow-shorthand.yml
Outdated
| - css.properties.overflow.visible | ||
| - css.types.overflow | ||
| - css.types.overflow.clip | ||
| - css.types.overflow.overlay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MDN has this to say about overlay:
Note: The keyword value overlay is a legacy value alias for auto. With overlay, the scroll bars are drawn on top of the content instead of taking up space.
Do you think the value should be marked as deprecated in BCD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. I removed and opened mdn/browser-compat-data#24877
features/text-overflow.yml
Outdated
| - css.properties.text-overflow.clip | ||
| - css.properties.text-overflow.ellipsis | ||
| - svg.global_attributes.text-overflow | ||
| - css.properties.text-overflow.string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This particular key seems interesting as it allows you to define your own ellipsis (if I understand correctly).
I'm tempted to make a separate feature for this. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a Custom ellipsis feature.
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One optional suggestion for you, but feel free to merge either way.
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
I set a
compute_fromwhere needed to maintain the existing baseline, as the new keys are non-impactful.