Skip to content

Conversation

@jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Oct 29, 2024

I set a compute_from where needed to maintain the existing baseline, as the new keys are non-impactful.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Oct 29, 2024
- css.properties.overflow.visible
- css.types.overflow
- css.types.overflow.clip
- css.types.overflow.overlay
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MDN has this to say about overlay:

Note: The keyword value overlay is a legacy value alias for auto. With overlay, the scroll bars are drawn on top of the content instead of taking up space.

Do you think the value should be marked as deprecated in BCD?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. I removed and opened mdn/browser-compat-data#24877

- css.properties.text-overflow.clip
- css.properties.text-overflow.ellipsis
- svg.global_attributes.text-overflow
- css.properties.text-overflow.string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This particular key seems interesting as it allows you to define your own ellipsis (if I understand correctly).
I'm tempted to make a separate feature for this. What do you think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a Custom ellipsis feature.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional suggestion for you, but feel free to merge either way.

Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@jamesnw jamesnw enabled auto-merge (squash) October 30, 2024 16:56
@jamesnw jamesnw merged commit 0770aaf into web-platform-dx:main Oct 30, 2024
3 checks passed
vwallen pushed a commit to oddbird/web-features that referenced this pull request Nov 5, 2024
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants