-
Notifications
You must be signed in to change notification settings - Fork 199
Add compat prefixed keys to recommended alternate features #2150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This situation is a bit messy. It implicates feature definitions and also BCD's structure and deprecated flag. See #86 and mdn/browser-compat-data#22958 for past discussion.
My preference is that we ought to mark such things as deprecated in BCD (or discouraged here, once we sort out #311). Looking over the spec, I expect that's a bit of work, since the text is a little equivocal. I think we'd have to check each one and find out if an unprefixed equivalent exists and only mark those as discouraged. That sounds hard and time consuming. So maybe we just need to set these things aside so we can clean them up later. Perhaps something we can do here and now is distinguish these items from their parent feature, but keep them closely together. Maybe something like… # resolution-compat.yml
name: resolution media query (compatibility prefixes)
description: The `-webkit-device-pixel-ratio`, `-webkit-min-device-pixel-ratio`, and `-webkit-max-device-pixel-ratio` CSS media queries are standardized compatibility alternatives to `resolution` media queries. |
…features; branch 'main' of github.com:web-platform-dx/web-features into resolution-prefixed
|
@ddbeck That makes sense to me. I split out |
|
Yeah, I think this looks OK. @Elchi3 would you have a look at this too? |
Elchi3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Two optional suggestions that would make things more consistent to my eyes.
Co-authored-by: Florian Scholz <fs@florianscholz.com>
These keys are a bit odd- they are in the Compat standard, meaning they only exist because they were essentially a standard, but you shouldn't use them. I don't think there is a clear reason to have a separate feature for these, but I could be convinced. The resolution addition is very straightforward, but the addition of
-webkit-transform-3dtosupportsis a bit odd, even though it is the recommended way of doing the same thing.