Skip to content

Conversation

@jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Nov 5, 2024

These keys are a bit odd- they are in the Compat standard, meaning they only exist because they were essentially a standard, but you shouldn't use them. I don't think there is a clear reason to have a separate feature for these, but I could be convinced. The resolution addition is very straightforward, but the addition of -webkit-transform-3d to supports is a bit odd, even though it is the recommended way of doing the same thing.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Nov 5, 2024
@ddbeck
Copy link
Collaborator

ddbeck commented Nov 5, 2024

This situation is a bit messy. It implicates feature definitions and also BCD's structure and deprecated flag. See #86 and mdn/browser-compat-data#22958 for past discussion.

you shouldn't use them

My preference is that we ought to mark such things as deprecated in BCD (or discouraged here, once we sort out #311).

Looking over the spec, I expect that's a bit of work, since the text is a little equivocal. I think we'd have to check each one and find out if an unprefixed equivalent exists and only mark those as discouraged. That sounds hard and time consuming. So maybe we just need to set these things aside so we can clean them up later.

Perhaps something we can do here and now is distinguish these items from their parent feature, but keep them closely together. Maybe something like…

# resolution-compat.yml
name: resolution media query (compatibility prefixes)
description: The `-webkit-device-pixel-ratio`, `-webkit-min-device-pixel-ratio`, and `-webkit-max-device-pixel-ratio` CSS media queries are standardized compatibility alternatives to `resolution` media queries.

…features; branch 'main' of github.com:web-platform-dx/web-features into resolution-prefixed
@jamesnw
Copy link
Collaborator Author

jamesnw commented Nov 6, 2024

@ddbeck That makes sense to me. I split out -webkit-transform-3d from supports as well- does that still make sense, even if it's not as 1:1?

@ddbeck
Copy link
Collaborator

ddbeck commented Nov 6, 2024

Yeah, I think this looks OK. @Elchi3 would you have a look at this too?

@ddbeck ddbeck requested a review from Elchi3 November 6, 2024 15:09
Copy link
Collaborator

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Two optional suggestions that would make things more consistent to my eyes.

Co-authored-by: Florian Scholz <fs@florianscholz.com>
@jamesnw jamesnw enabled auto-merge (squash) November 6, 2024 17:35
@jamesnw jamesnw merged commit 37f6cf0 into web-platform-dx:main Nov 6, 2024
3 checks passed
@jamesnw jamesnw deleted the resolution-prefixed branch November 12, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants