Adds additional font related keys #2151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
jamesnw
reviewed
Nov 8, 2024
jamesnw
approved these changes
Nov 8, 2024
Collaborator
jamesnw
left a comment
jamesnw
left a comment
There was a problem hiding this comment.
This looks good to me, but I'll leave open for a bit in case a non-Oddbirder wants to review.
ddbeck
reviewed
Nov 11, 2024
features/colrv0.yml
Outdated
| @@ -0,0 +1,7 @@ | |||
| name: COLRv0 | |||
| description: COLRv0 is a font format that supports multi-color glyphs. | |||
Collaborator
There was a problem hiding this comment.
Can we say something, either here or in v1, that distinguishes the two formats?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most keys fit into existing features.
colorv0is given its own feature to matchcolrv1and because it has its owncaniusekey