Add Sourcemap header #2184
Merged
Add Sourcemap header #2184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
ddbeck
reviewed
Nov 7, 2024
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
features/sourcemaps.yml
Outdated
| @@ -0,0 +1,5 @@ | |||
| name: Source maps | |||
Contributor
There was a problem hiding this comment.
I think we should make this name more specific to the fact that this feature is about the HTTP header. There are multiple ways to load source maps into DevTools, and using the HTTP response header is one of them.
Other ways include:
- By including comments in JS:
//# sourceMappingURL=... - Automatically, by using Edge DevTools' Symbol Server integration.
- Manually in DevTools.
Maybe change the name to "Source map header"?
Collaborator
Author
There was a problem hiding this comment.
Thanks Patrick, in this case, yes, I think the correct thing would be to make this feature just about the header.
ddbeck
approved these changes
Nov 12, 2024
Collaborator
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
I'm happy to see this merge, but I'll leave it to Patrick or Florian to decide whether to merge with or without Patrick's re-review. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I'm not sure if we want "SourceMap" or "Source maps". I think more people talk about it as "Source maps"
Edit: As Patrick notes, this is just the header and not general source maps support