-
Notifications
You must be signed in to change notification settings - Fork 199
Adds features from CSS 2 (@charset, float & clear, vertical-align) #2216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
36afce2
Adds vertical align feature
vwallen 47c839d
Adds float and clear feature
vwallen d7d2e48
Adds charset at-rule
vwallen d5e0e64
Adds table specific CSS properties to table feature
vwallen f2456d7
Text fixes
vwallen 3221379
Adds additional caption style keys
vwallen f8e5fac
Updates keys
vwallen dd31049
Merge branch 'main' of https://github.com/web-platform-dx/web-feature…
vwallen b921d72
Updates dist
vwallen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| name: "@charset" | ||
| description: The `@charset` CSS at-rule specifies the character encoding of an external style sheet. | ||
| spec: https://drafts.csswg.org/css2/#charset | ||
| group: css | ||
| compat_features: | ||
| - css.at-rules.charset |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Generated from: charset.yml | ||
| # Do not edit this file by hand. Edit the source file instead! | ||
|
|
||
| status: | ||
| baseline: high | ||
| baseline_low_date: 2015-07-29 | ||
| baseline_high_date: 2018-01-29 | ||
| support: | ||
| chrome: "2" | ||
| chrome_android: "18" | ||
| edge: "12" | ||
| firefox: "1.5" | ||
| firefox_android: "4" | ||
| safari: "4" | ||
| safari_ios: "4" | ||
| compat_features: | ||
| - css.at-rules.charset |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| name: float and clear | ||
| description: The `float` CSS property aligns an element to either side of its container, allowing text and inline elements to flow around it. The `clear` CSS property sets whether an element is moved below floating elements that proceed it. | ||
| spec: | ||
| - https://drafts.csswg.org/css2/#propdef-float | ||
| - https://drafts.csswg.org/css2/#propdef-clear | ||
| group: css | ||
| compat_features: | ||
| - css.properties.clear | ||
| - css.properties.clear.both | ||
| - css.properties.clear.left | ||
| - css.properties.clear.right | ||
| - css.properties.float | ||
| - css.properties.float.left | ||
| - css.properties.float.none | ||
| - css.properties.float.right |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Generated from: float-clear.yml | ||
| # Do not edit this file by hand. Edit the source file instead! | ||
|
|
||
| status: | ||
| baseline: high | ||
| baseline_low_date: 2015-07-29 | ||
| baseline_high_date: 2018-01-29 | ||
| support: | ||
| chrome: "1" | ||
| chrome_android: "18" | ||
| edge: "12" | ||
| firefox: "1" | ||
| firefox_android: "4" | ||
| safari: "1" | ||
| safari_ios: "1" | ||
| compat_features: | ||
| - css.properties.clear | ||
| - css.properties.clear.both | ||
| - css.properties.clear.left | ||
| - css.properties.clear.right | ||
| - css.properties.float | ||
| - css.properties.float.left | ||
| - css.properties.float.none | ||
| - css.properties.float.right |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| name: vertical-align | ||
| description: The `vertical-align` CSS property sets the vertical alignment of inline, inline-block, and table cell elements. It has no effect on block-level elements. | ||
| spec: https://drafts.csswg.org/css2/#propdef-vertical-align | ||
| group: css | ||
| compat_features: | ||
| - css.properties.vertical-align | ||
| - css.properties.vertical-align.baseline | ||
| - css.properties.vertical-align.bottom | ||
| - css.properties.vertical-align.middle | ||
| - css.properties.vertical-align.sub | ||
| - css.properties.vertical-align.super | ||
| - css.properties.vertical-align.text-bottom | ||
| - css.properties.vertical-align.text-top | ||
| - css.properties.vertical-align.top |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Generated from: vertical-align.yml | ||
| # Do not edit this file by hand. Edit the source file instead! | ||
|
|
||
| status: | ||
| baseline: high | ||
| baseline_low_date: 2015-07-29 | ||
| baseline_high_date: 2018-01-29 | ||
| support: | ||
| chrome: "1" | ||
| chrome_android: "18" | ||
| edge: "12" | ||
| firefox: "1" | ||
| firefox_android: "4" | ||
| safari: "1" | ||
| safari_ios: "1" | ||
| compat_features: | ||
| - css.properties.vertical-align | ||
| - css.properties.vertical-align.baseline | ||
| - css.properties.vertical-align.bottom | ||
| - css.properties.vertical-align.middle | ||
| - css.properties.vertical-align.sub | ||
| - css.properties.vertical-align.super | ||
| - css.properties.vertical-align.text-bottom | ||
| - css.properties.vertical-align.text-top | ||
| - css.properties.vertical-align.top |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These CSS properties apply specifically to table elements or sub-elements. They could conceivably be split into a table styles feature or two features, related to border styles and caption styles. This seemed the most straightforward