Add WebRTC #2232
Merged
Add WebRTC #2232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
Contributor
Author
|
@ddbeck ready for a first pass on the approach. |
Contributor
Author
|
There are also a few candidates for sub-features if we want to cleave those off into their own thing, eg the error stuff. |
Contributor
Author
|
Baseline low/false chunks we could split off if you want a more cleanly baseline high core feature:
|
ddbeck
requested changes
Nov 18, 2024
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
ddbeck
reviewed
Nov 19, 2024
Collaborator
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
A couple little fixes to make. Otherwise, I think this is ready.
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had a
webrtcgroup, and three features: WebRTC, WebRTC SCTP, WebRTC Encoded Transform.Core: Adds more keys into the core feature that were in the spec generated draft, and then all the other misc keys from BCD that weren't yet in here and were not obsolete.
Stats API: Added the WebRTC Stats API as its own thing, since is a huge number of keys related solely to that and we've already cleaved off subfeatures. If we want to go megafeature, happy to roll it back in.
Identity: No action yet. Baseline false, there are a few keys from the that spec which are implemented by different browsers. Likely could be its own sub-feature since is designed to bolt on top.
Priority: No action yet. Single vendor, couple of keys.