Add Ambient light sensor #2245
Merged
Add Ambient light sensor #2245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
autonome
approved these changes
Nov 18, 2024
Contributor
autonome
left a comment
autonome
left a comment
There was a problem hiding this comment.
A fix for the description comment would be great if it's actually needed, looks good otherwise.
features/ambient-light.yml
Outdated
| @@ -0,0 +1,11 @@ | |||
| name: Ambient light sensor | |||
| description: The `AmbientLightSensor` interface returns the current light level or illuminance of the ambient light around the device. | |||
Contributor
There was a problem hiding this comment.
current light level or illuminance of the ambient light around the device
Are these two different things? The MDN docs only show the one property that I can see.
Collaborator
There was a problem hiding this comment.
Also, the sensor APIs are a bit weird, right? They receive sensor reading events, rather than returning data themselves?
Elchi3
commented
Nov 21, 2024
autonome
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/API/AmbientLightSensor