Adds additional contain features and keys #2252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
jamesnw
requested changes
Nov 21, 2024
Collaborator
jamesnw
left a comment
jamesnw
left a comment
There was a problem hiding this comment.
A few minor changes, but looks good!
Co-authored-by: James Stuckey Weber <jamesnw@gmail.com>
ddbeck
reviewed
Nov 26, 2024
features/content-visibility.yml.dist
Outdated
| status: | ||
| baseline: low | ||
| baseline_low_date: 2024-09-16 | ||
| baseline: false |
Collaborator
There was a problem hiding this comment.
Since we're regressing the status, would you add a comment to the authored yaml file with a note as in #1973?
Collaborator
There was a problem hiding this comment.
This should no longer be a regression with mdn/browser-compat-data#25186 in 5.6.19.
Collaborator
There was a problem hiding this comment.
There are now no status changes here.
jamesnw
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a feature for the
containproperty itself, to include the higher level keywords valuesnone,strict, andcontentwhich are either the default (no containment) or aliases for already included keyword values.The main key
css.properties.containis already included in a keyword feature. I'm not sure of the protocol for moving a key from one feature to another, but if thecontainfeature is accepted as-is, it should reclaim that key.Also adding keys to the
content-visibilityfeature which required an updatecompute_fromto maintain consistent support reporting