Add keys to array feature #2268
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
javascript.builtins.Array.@@unscopablesandjavascript.builtins.Array.@@speciestoarray.So far the
arrayfeature was sort of "pure" and only contained original keys with the same version, but I really don't know where else to sort these two keys. I think if we were to author thearrayfeatures today, more keys would probably move into the mainarrayfeature as they are old enough.It is unfortunate that web-features doesn't define when such a move into the main feature should happen. I think the project would benefit from having a lintable rule here to avoid being inconsistent. Something like: "If a sub feature is baseline high for more than 3 years, the sub feature should be merged with the main feature." For
array, this would mean that features likearray-iterators,array-isarray,array-fill, and more would be merged intoarray, for example. cc @ddbeck