Unsilence validation errors #2444
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, we were silently ignoring all validation errors. 🤦
This fixes the issues in
validate.tsandbuild.ts. It also fixes the individual validation errors.One of these validation errors is a bit pedantic: some URLs get rejected for failing to match the
uristring format. According to JSON Schema, a URI strictly follows RFC3986, which is ASCII only. Instead of rewriting those URIs, I chose to drop theuriformat from the schema. Points in favor:I don't think this is a breaking change—it's still a string, we're not changing the meaning or scope of those strings, and no one has complained up to now that we're producing non-RFC3986 strings already—but I'd welcome a review of that aspect in particular.