Skip to content

Update prerelease without creating needless notifications #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2024
Merged

Update prerelease without creating needless notifications #2454

merged 1 commit into from
Dec 18, 2024

Conversation

@ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Dec 17, 2024

I think this fixes #2068 again and supersedes #2453.

This version does these steps:

  • Sets the existing pre-release to draft
  • Advances the release tag
  • Edits the existing pre-release with the latest details and publishes it again

On my fork, this prevented the notifications that @szepeviktor reported.

@github-actions github-actions bot added the tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings label Dec 17, 2024
@ddbeck ddbeck mentioned this pull request Dec 17, 2024
Closed
@szepeviktor
Copy link
Contributor

szepeviktor commented Dec 17, 2024

All right.
I hope it won't trigger a release notification.

image

jamesnw
jamesnw approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, and I did not get any notifications when I ran it on my branch.

@ddbeck ddbeck merged commit 24c5def into web-platform-dx:main Dec 18, 2024
4 checks passed
@ddbeck ddbeck deleted the advance-release-date-again branch December 18, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesnw jamesnw jamesnw approved these changes

Assignees

No one assigned

Labels

tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@next GitHub release date does not advance

3 participants

@ddbeck @szepeviktor @jamesnw