-
Notifications
You must be signed in to change notification settings - Fork 199
Add discouraged CSS features #2486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
captainbrosset
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a suggestion for the missing description.
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some ideas here, mostly to avoid having to stuff discouraged information into the IDs and descriptions.
| @@ -0,0 +1,11 @@ | |||
| name: color-adjust | |||
| description: The `color-adjust` shorthand CSS property allows multiple performance related color adjustments to be set at once. Setting the `print-color-adjust` CSS property directly is preferred, as it is the only such adjustment so far defined. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking, just noting something here: we ought to come up with guidelines for whether to summarize the alternatives in the description or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
media-queries-deprecated.yml → device-queries.yml
(c.f. several other media query features) and see below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
features/writing-mode-deprecated.yml → features/writing-mode-svg-values.yml
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nit, but this is ready to merge at your convenience.
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Credit to @vwallen for the content.