Skip to content

Conversation

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Jan 9, 2025
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor issues around names and descriptions, but BCD is giving me a little headache here.

@@ -0,0 +1,12 @@
name: In-app install experience
description: On browsers that support installing Progressive Web Apps (PWAs), the `beforeinstallprompt` event can be used to defer the browser installation flow until when the user interacts with an in-app install button.
spec: https://wicg.github.io/manifest-incubations/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is pretty interesting. In the course of trying to figure out whether there was a more specific link to use here, I got to wondering why MDN doesn't link to this spec. That turned up these PRs:

This puts us in a slightly awkward spot here. BCD shows unqualified support for the API, even where it departs from the spec (because it effectively pretends the spec doesn't exist). We have some options here:

  • If we were to link to the spec, we're sort of implying that the Chrome and Edge support for this feature reflects support for this specification.
  • Not linking to a specification at all is a difficult alternative (not least of which being that the schema requires it)—what even is the feature, at that point, if we can't point to a definition?
  • We could go upstream and unroll some of Will's changes to the compat data, breaking correspondence between MDN content and BCD.
  • Override BCD's status.

Or maybe something I haven't thought of yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally link to the spec like what's done here. There's no other spec to link to, but leave a comment saying that the only implementation that currently exists is in Chromium, and that it differs from the spec. And then, work with WICG to update the spec, which I think WICG/manifest-incubations#36 is about.

@captainbrosset captainbrosset requested a review from ddbeck January 28, 2025 15:50
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @captainbrosset. I like your description and I'm happy with this compromise around the spec.

@ddbeck ddbeck merged commit c69f545 into main Jan 28, 2025
3 checks passed
@ddbeck ddbeck deleted the in-app-install branch January 28, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants