-
Notifications
You must be signed in to change notification settings - Fork 199
BeforeInstallPrompt feature #2510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor issues around names and descriptions, but BCD is giving me a little headache here.
features/in-app-install.yml
Outdated
| @@ -0,0 +1,12 @@ | |||
| name: In-app install experience | |||
| description: On browsers that support installing Progressive Web Apps (PWAs), the `beforeinstallprompt` event can be used to defer the browser installation flow until when the user interacts with an in-app install button. | |||
| spec: https://wicg.github.io/manifest-incubations/ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is pretty interesting. In the course of trying to figure out whether there was a more specific link to use here, I got to wondering why MDN doesn't link to this spec. That turned up these PRs:
- Update beforeinstallpromptevent mdn/content#26828
- BeforeInstallPromptEvent.prompt() is non-standard mdn/browser-compat-data#19910
This puts us in a slightly awkward spot here. BCD shows unqualified support for the API, even where it departs from the spec (because it effectively pretends the spec doesn't exist). We have some options here:
- If we were to link to the spec, we're sort of implying that the Chrome and Edge support for this feature reflects support for this specification.
- Not linking to a specification at all is a difficult alternative (not least of which being that the schema requires it)—what even is the feature, at that point, if we can't point to a definition?
- We could go upstream and unroll some of Will's changes to the compat data, breaking correspondence between MDN content and BCD.
- Override BCD's status.
Or maybe something I haven't thought of yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would personally link to the spec like what's done here. There's no other spec to link to, but leave a comment saying that the only implementation that currently exists is in Chromium, and that it differs from the spec. And then, work with WICG to update the spec, which I think WICG/manifest-incubations#36 is about.
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @captainbrosset. I like your description and I'm happy with this compromise around the spec.
Learn more: