Add element-capture feature
#2562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
foolip
approved these changes
Feb 10, 2025
Collaborator
foolip
left a comment
foolip
left a comment
There was a problem hiding this comment.
Description could be polished perhaps, but no further review needed.
features/element-capture.yml
Outdated
| @@ -0,0 +1,7 @@ | |||
| name: Element capture | |||
| description: The `RestrictionTarget` API captures video from a specific element, excluding content which might occlude the element itself, such as video conferencing controls. | |||
Collaborator
There was a problem hiding this comment.
Although you need to call RestrictionTarget.fromElement() first, I think it makes more sense to call out the restrictTo() method as the entrypoint for this feature. Something like
The
restrictTo()method for screen capture media track ...
Spelling out exactly what a "screen capture media track" is would be a bit of work, it's a BrowserCaptureMediaStreamTrack which can be returned from getDisplayMedia() (but isn't always IIUC).
Collaborator
Author
There was a problem hiding this comment.
I don't think we have to explain that much. Revised with cf5715e. Thank you!
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description based on reading https://developer.chrome.com/docs/web-platform/element-capture.