-
Notifications
You must be signed in to change notification settings - Fork 199
Add document.write() feature #2643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
…res into document-write
|
@ddbeck interestingly, adding the two For consumers who only care about the baseline status, nothing to worry about. |
This was a bug in a somewhat complex set of conditionals. Helps along web-platform-dx#2643
This was a bug in a somewhat complex set of conditionals. This also removes the warnings about deprecated keys, since we allow them in certain settings. Helps along web-platform-dx#2643
|
@captainbrosset you found a bug! I sent #2689 to fix it. Here's what that fix would look like on this branch: document-write...ddbeck:web-features:fix-document-write |
This was a bug in a somewhat complex set of conditionals. This also removes the warnings about deprecated keys, since we allow them in certain settings. Helps along #2643
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review on the other PR, Patrick! I've merged main into this branch and refreshed the dist. All is well now.
document.open and document.close are not discouraged in the spec, but they're only useful for document.write anyway, so we might as well group all of these related methods together in a new discouraged feature.