Skip to content

Allow discouraged features to use compute_from #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Allow discouraged features to use compute_from #2689

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f8ae6d
Allow discouraged features to use `compute_from`
ddbeck Feb 21, 2025
d0b7009
Remove spurious debugging text
ddbeck Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 12 additions & 22 deletions scripts/dist.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,17 +233,13 @@ function toDist(sourcePath: string): YAML.Document {
checkAncestors: true,
});

if (computedStatus.discouraged && !source.discouraged) {
if (!source.draft_date) {
logger.error(
`${id}: contains at least one deprecated compat feature. This is forbidden for published features.`,
);
exitStatus = 1;
} else {
logger.warn(
`${id}: draft contains at least one deprecated compat feature. Was this intentional?`,
);
}
const deprecatedKeysAllowed = source.draft_date || source.discouraged;

if (computedStatus.discouraged && !deprecatedKeysAllowed) {
logger.error(
`${id}: contains at least one deprecated compat feature. This is forbidden for non-discouraged published features.`,
);
exitStatus = 1;
}

computedStatus = JSON.parse(computedStatus.toJSON());
Expand Down Expand Up @@ -283,17 +279,11 @@ function toDist(sourcePath: string): YAML.Document {

for (const key of compatFeatures) {
const f = feature(key);
if (f.deprecated) {
if (!source.draft_date) {
logger.error(
`${id}: contains contains deprecated compat feature ${f.id}. This is forbidden for published features.`,
);
exitStatus = 1;
} else {
logger.warn(
`${id}: draft contains deprecated compat feature ${f.id}. Was this intentional?`,
);
}
if (f.deprecated && !deprecatedKeysAllowed) {
logger.error(
`${id}: contains contains deprecated compat feature ${f.id}. This is forbidden for non-discouraged published features.`,
);
exitStatus = 1;
}
}
}
Expand Down