Reject hidden caniuse features #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
approved these changes
Nov 10, 2023
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
This is a temporary fix until `@types/caniuse-lite` is fixed. See also: DefinitelyTyped/DefinitelyTyped#67330
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build will fail on this PR becauseI've temporarily overridden the type so we can move on with this.@types/caniuse-lite's type definitions are out of date. See: DefinitelyTyped/DefinitelyTyped#67330.This PR checks that features'
caniusevalues point only to features that appear on caniuse.com. It disallows caniuse ID where the caniuseshownproperty isfalse.This impacts the caniuse burndown list. I've chosen to mark them as complete, but also to note that they're hidden features.
This PR closes #275.