-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebDriver Bidi tests with new Py3 WebSockets dependencies #26510
Commits on Dec 15, 2020
-
Make sure mMaxLength exists in SetSelectionRange
Cloning a textarea element without a dirty value flag does not call SetValue() and thus gets no max length. This makes sure it always gets one before setting selection range. Differential Revision: https://phabricator.services.mozilla.com/D99734 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1682313 gecko-commit: 80e51db676d263d2563f2ef10a1c50c617e2853e gecko-reviewers: masayuki
Configuration menu - View commit details
-
Copy full SHA for e0f5bf4 - Browse repository at this point
Copy the full SHA e0f5bf4View commit details -
Copy defined state to static clones.
Differential Revision: https://phabricator.services.mozilla.com/D99632 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1682159 gecko-commit: b90e93c4aa5c76dfe14a05f8e7bcbdfbcc78c24f gecko-reviewers: edgar
Configuration menu - View commit details
-
Copy full SHA for 7647a1f - Browse repository at this point
Copy the full SHA 7647a1fView commit details -
Fix ShapeDetection handling of broken HTMLImageElements
When an HTMLImageElement's 'src' is set to the empty string, the state of the image request will be 'broken', and thus the promise should be rejected with an InvalidStateError exception per the rules at [1]. Move the intrinsic size check below the image existence check, and use a more direct method of getting at the size (no need to go through the BitmapImageSource interface when we're already fiddling with internals). Also add a check for IsLoaded() to better match the spec wording 'fully decodable'. [1] https://wicg.github.io/shape-detection-api/#image-sources-for-detection Bug: 789511 Change-Id: I69ac4a9081cfff7f9c7c8f7edf39667e3dd1eb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587165 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#837140}
Configuration menu - View commit details
-
Copy full SHA for 245cc25 - Browse repository at this point
Copy the full SHA 245cc25View commit details -
[Frame Policy] Add test to verify frame policy works correctly in jav…
…ascript url Previous fix(https://chromium-review.googlesource.com/c/chromium/src/+/2181318) on uninitialized frame policy in javascript url navigation does not include a test case because it is a security fix. Since the fix has landed in M84 which is stable right now, this CL adds the test case for the fix. Bug: 1074340 Change-Id: Ia10a972183b02cdac28a2f29cabb7f13caf168e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297708 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#837169}
Configuration menu - View commit details
-
Copy full SHA for 67b62d4 - Browse repository at this point
Copy the full SHA 67b62d4View commit details -
[Gecko Bug 1680114] [wdspec] Session fixture has to deep update custo…
…m capabilities. (web-platform-tests#26741) * [wdspec] Session fixture has to deep update custom capabilities. Differential Revision: https://phabricator.services.mozilla.com/D98459 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1680114 gecko-commit: 6e45b8c280e020d31f69085bf5b77d5b4186ce27 gecko-reviewers: webdriver-reviewers, jgraham * Fix use of iteritems in WebDriver helpers Differential Revision: https://phabricator.services.mozilla.com/D99253 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1680114 gecko-commit: d3fa09337a9a4cbf8233e49295baa5e57dbedd57 gecko-reviewers: whimboo, webdriver-reviewers
Configuration menu - View commit details
-
Copy full SHA for 7eb8ccd - Browse repository at this point
Copy the full SHA 7eb8ccdView commit details -
Remove all Shadow DOM v0 and Custom Elements v0 Code
These APIs have been deprecated since Aug 2018 [1], disabled by default since Oct 2019 [2], and removed from Origin Trial support since Oct 2020 [3]. This CL removes the code to support these two features completely. This is being done in one large CL for two reasons: 1. It is hard to untangle all of the dependencies of this code to be able to land this in multiple CLs. 2. Doing this in a single CL will allow the effects (progressions, hopefully, but we'll see) to be more easily tracked. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/h-JwMiPUnuU/sl79aLoLBQAJ [2] https://chromium-review.googlesource.com/c/chromium/src/+/1850795 [3] https://chromium-review.googlesource.com/c/chromium/src/+/2458126 Bug: 937746, 1157927, 1158001 Fixed: 1129465 Fixed: 1157500 Change-Id: I45d77960fa77e2bba3f5b301e3fb7372bb659c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586019 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by: Yu Han <yuzhehan@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#837213}
Configuration menu - View commit details
-
Copy full SHA for 3e27ba6 - Browse repository at this point
Copy the full SHA 3e27ba6View commit details -
Reland "Use skia.mojom.BitmapN32 in Detection mojoms"
This is a reland of c7326b7f5dd47cddf6ff99d98fd1b7be1f54f922 Canvases may have different color formats than N32, and when we pull the content of them into a cpu bitmap through SkImage::toLegacyBitmap() we need to convert that to N32 format if we're going to send the bitmap over IPC due to security restrictions of the BitmapN32 mojom type. This does that conversion in the blink ShapeDetector and adds a test with a float16 color format canvas which would cause the IPC sending to be dropped (and the renderer to crash). TBR=dcheng Original change's description: > Use skia.mojom.BitmapN32 in Detection mojoms > > These bitmaps are safer for transport from untrustworthy sources since > all bitmaps should be in N32 format and the browser can make bad > assumptions as a result. > > R=dcheng@chromium.org, reillyg@chromium.org > > Bug: 1144462 > Change-Id: I7d02cb187c62be37259f445a182f8c971aa03661 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580483 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835685} Bug: 1144462 Change-Id: I23ef3df85049a7111830c5d272c02b69f9d7cd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593827 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#837241}
Configuration menu - View commit details
-
Copy full SHA for ed3c1d0 - Browse repository at this point
Copy the full SHA ed3c1d0View commit details -
Rename InputMethodKeyboard* to VirtualKeyboard* to be more specific
All functionality related to InputMethodKeyboard* were designed to handle the onscreen / virtual keyboard. The class is not directly related to InputMethods. Hence, should be renamed to VirtualKeyboard*. Bug: 1158633 Change-Id: I06569bcae62755826bfc7dcf479a29dd90db7175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592207 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#837272}
Configuration menu - View commit details
-
Copy full SHA for cbf94f4 - Browse repository at this point
Copy the full SHA cbf94f4View commit details
Commits on Dec 16, 2020
-
[WebXR] Add OffscreenCanvas support for makeXrCompatible
When an offscreen canvas doesn't have a placeholder canvas (such as when new OffscreenCanvas(width, height) is called to create an offscreen canvas in javascript), the corresponding C++ object is OffscreenCanvas, not HTMLCanvasElement. This change obtains the XRSystem object from the OffscreenCanvas so that MakeXrCompatible can be called on it. Bug: 1154424 Change-Id: I4fb1c7005a8c3a41cc4ddcd457c81c4bec4464ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578710 Reviewed-by: Brandon Jones <bajones@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#837356}
Configuration menu - View commit details
-
Copy full SHA for 7937f21 - Browse repository at this point
Copy the full SHA 7937f21View commit details -
URLPattern: Resolve relative pathnames and canonicalize URL input.
This CL makes a number of improvements: * It removes the http/https specific assumption that pathnames always consist of at least a leading slash. * Resolve relative pathnames for both patterns and URL input. This is only done if the baseURL is a standard URL with a pathname containing slashes. * Canonicalizes URL input values. * Validates pattern values are ASCII, but does not perform any encoding or canonicalization yet. Bug: 1141510 Change-Id: I6db1afe77f6dd1d15ccb2e96a51412a31257efba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579989 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#837371}
1Configuration menu - View commit details
-
Copy full SHA for c7a45aa - Browse repository at this point
Copy the full SHA c7a45aaView commit details -
[css-text] Support for break-spaces with trailing ideographic spaces
This CL add the logic, for both Legacy and LayoutNG, for handling trailing ideographic spaces when the white-space CSS property is set to 'break-spaces' value. The CSS Text specification states [1] that we must prevent handing or collapsing the advance width of any space, including other space separator like ideographic spaces, hence the overflowing spaces must wrap to the next line. However, the spec also states in the description of the 'break-spaces' value [2] that breaking opportunities exists 'after' any space; hence, breaking before the first ideographic space of the sequence is not allowed, so it may overflow in that case. [1] https://drafts.csswg.org/css-text-3/#white-space-phase-2 [2] https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces Bug: 1155633 Change-Id: Id34f05cb3457516fcb20a4731606425ec943a255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584854 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#837379}
1Configuration menu - View commit details
-
Copy full SHA for 2350fb2 - Browse repository at this point
Copy the full SHA 2350fb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5034ab1 - Browse repository at this point
Copy the full SHA 5034ab1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48e3fd2 - Browse repository at this point
Copy the full SHA 48e3fd2View commit details -
Fix WPT for referrer policy inheritance
Executing a javascript: URL does not commit a new document, and executing a javascript: URL in a srcdoc iframe does not change the fact that this is a srcdoc iframe. (cf https://crrev.com/c/2464930). On the other side, the algorithm for computing the referrer of a srcdoc iframe defers to the parent: https://w3c.github.io/webappsec-referrer-policy/#strip-url Bug: 1043895 Change-Id: I144aa288204f9e92d1b41b0f3c64bc0d6274f10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582045 Reviewed-by: David Van Cleve <davidvc@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#837504}
Configuration menu - View commit details
-
Copy full SHA for cda6b2f - Browse repository at this point
Copy the full SHA cda6b2fView commit details -
Fix nullptr dereference accessing PolicyContainer in Blink
When parsing a referrer policy from a meta tag, we were trying to update the PolicyContainer (and with it, the PolicyContainerHost in the Browser process) without checking for it not to be nullptr. However, the PolicyContainer is nullptr for LocalFrames which have no RenderFrameHost counterpart in the browser, which are used for rendering SVG images. As a consequence, there are cases in which a meta tag in an SVG image made the renderer crash. This change adds a nullptr check to fix this. Bug: 1158034, 1130587 Change-Id: Ia0b5c51b4d1d68cfd7329da8c5e153bdef7deb3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593000 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#837507}
Configuration menu - View commit details
-
Copy full SHA for 4363082 - Browse repository at this point
Copy the full SHA 4363082View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5568508 - Browse repository at this point
Copy the full SHA 5568508View commit details -
Address flakiness with webaudio/the-audio-api/the-pannernode-interfac…
…e/panner-distance-clamping.html (web-platform-tests#26926) Make sure the test prints its PASS lines in a consistent order to address flakiness as part of the WebKit test suite. Co-authored-by: Chris Dumez <cdumez@apple.com>
1Configuration menu - View commit details
-
Copy full SHA for dfd29f2 - Browse repository at this point
Copy the full SHA dfd29f2View commit details -
Ignore layout shift when visibility:hidden becomes visible
We should ignore layout shift if the object was ineligible for layout shift tracking during the previous paint invalidation. Add LayoutObject::ShouldSkipNextLayoutShiftTracking() and set it during paint invalidation if the object is ineligible for layout shift tracking. In the next paint invalidation, if the flag is true, skip layout shift tracking and reset the flag. This also applies to content-visibility:auto for which we cleared LayoutBox's previous size to prevent layout shift tracking for the next cycle. The new flag is basically equivalent to the old method, but also covers more cases, e.g. the old method would fail if the object had visual overflow because PreviousPhysicalVisualOverflowRect() was not based on PreviousSize() and empty. Bug: 1152869 Change-Id: I000489dd8093dab8d2ab3605ad4ce3bd39fd11b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591367 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837627}
Configuration menu - View commit details
-
Copy full SHA for 85a49cb - Browse repository at this point
Copy the full SHA 85a49cbView commit details -
Add html/interaction/focus/document-level-focus-apis/document-has-sys…
…tem-focus.html (web-platform-tests#26845) * Add html/interaction/focus/document-level-focus-apis/document-has-system-focus.html * Ensure document has focus as precondition. * Try to have popup steal focus in more browsers. * Move event handlers earlier to avoid possible race.
1Configuration menu - View commit details
-
Copy full SHA for 15ff084 - Browse repository at this point
Copy the full SHA 15ff084View commit details -
Re-write wpt/cookies/http-state/c* tests (web-platform-tests#26847)
This CL rewrites the tests contained in charset-tests.html, chromium-tests.html,and comma-tests.html. It also creates httpCookieTest (inside cookie-test.js) and rewrites tests to use it. The idea is that we probably want to have a domCookieTest in the future, and this will make it less messy. Relates to web-platform-tests#26190 Bug: 1152798 Change-Id: If5fa785b5b14c2596445ab1c7ac0926209f04314 Co-authored-by: Mike Taylor <miketaylr@chromium.org>
Configuration menu - View commit details
-
Copy full SHA for ed55023 - Browse repository at this point
Copy the full SHA ed55023View commit details -
Update interfaces/mediastream-recording.idl (web-platform-tests#26929)
Configuration menu - View commit details
-
Copy full SHA for 62d5fc5 - Browse repository at this point
Copy the full SHA 62d5fc5View commit details -
Add .type property to WASM Memory, Table & Global r=lth
This is part of adding type reflections to the WebAssembly JS-API. This adds a new property on the WebAssembly.Memory, WebAssembly.Table & WebAssembly.Global objects. It exposes the current type or the object in a format which is compatible with the constructor for type's constructor. Differential Revision: https://phabricator.services.mozilla.com/D90702 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1651725 gecko-commit: dff33d0b33c8fb168966504f5562572ddec72a8e gecko-reviewers: lth
Configuration menu - View commit details
-
Copy full SHA for a08c466 - Browse repository at this point
Copy the full SHA a08c466View commit details
Commits on Dec 17, 2020
-
Canvas-WCG: Update names to reflect the specification
Change "p3" color space to "display-p3". This is the name used in the specification and in the CSS color level 4 specification (which is shipping on Safari). Of note is that is that the color gamut media queries use "p3" instead of "display-p3". This could be intentional (reflecting the P3 *primaries* common to DCI P3 and Display P3 *color spaces*), or may be accidental. Change ImageDataColorSettings to ImageDataSettings. Right now all of the settings are for color, but the spec doesn't put color in the name because of future plans to add other settings (like premultiplied alpha). The largest remaining inconsistency is that "pixelFormat" versus "storageFormat" and "uint8" versus "unorm8". R=yiyix TBR=fserb Bug: 1083693 Change-Id: I8e6d476a17fd2fca8da6b7901bb1098253a61559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594269 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#837682}
Configuration menu - View commit details
-
Copy full SHA for d3ec3f4 - Browse repository at this point
Copy the full SHA d3ec3f4View commit details -
Ignore layout shift under opacity:0
Bug: 1152869 Change-Id: Ie68a761a3cd2a81dcdd3de6d2469d64146c3f596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591907 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#837687}
Configuration menu - View commit details
-
Copy full SHA for 8ff7fcc - Browse repository at this point
Copy the full SHA 8ff7fccView commit details -
Avoid double relpos offset in NGSimplifiedOOFLayoutAlgorithm.
The offsets stored in NGLink are "paint offsets", which include any offsets caused by relative positioning. The fragment builder, on the other hand, expects "layout offsets", which shouldn't include that. The fragment builder adds the relative offset on its own at the right time. I struggled with coming up with a very sensible test, since fragmentation of out-of-flow descendants is incorrectly affected by the inset specified on their relatively positioned containing block (see crbug.com/1158387 and crbug.com/1158756 ). Bug: 1079031 Change-Id: I803dd89a11be2ba9179e20ea06d0b709d08ab534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593005 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#837692}
Configuration menu - View commit details
-
Copy full SHA for 7f9225b - Browse repository at this point
Copy the full SHA 7f9225bView commit details -
[AspectRatio] Correctly detect indefinite percentages
The block size may be a percentage, in which case we would think the extent is definite on the final pass through this function, even if it is an indefinite percentage. Fix this by using BlockLengthUnresolvable. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1154572 Change-Id: Ia70dc730d4fee2005904942afa4020f9074f4eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595248 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#837699}
Configuration menu - View commit details
-
Copy full SHA for bc05868 - Browse repository at this point
Copy the full SHA bc05868View commit details -
Handle inner floated multicol at outer boundary.
This used to crash, because we ignored layout abortions on floats, and would attempt to use the fragment (which is nullptr). Bug: 829028 Change-Id: I04c44030d33182fd3020e8091228668d7f8a7190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592805 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#837713}
Configuration menu - View commit details
-
Copy full SHA for ed5cae4 - Browse repository at this point
Copy the full SHA ed5cae4View commit details -
Handle inner fieldset / legend multicol at outer boundary.
This used to fail a DCHECK when nested multicol was specified on a fieldset at an outer fragmentainer boundary, but apart from that, it worked fine, because BreakBeforeChildIfNeeded() correctly detects the situation (abortion) and inserts a break before. Just move the DCHECK a bit down. No code changes are required for legends, as they are monolithic. Just replace the TODO with a proper comment, and keep the DCHECK (the legend test also passes without the code changes in this CL). Bug: 829028 Change-Id: I62bf97f9bd04c185f86e93103f204cc6d872c438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595288 Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#837755}
Configuration menu - View commit details
-
Copy full SHA for 170a516 - Browse repository at this point
Copy the full SHA 170a516View commit details -
Add explicit [Exposed] to ReadableStreamDefaultController WebIDL
This CL adds an explicit [Exposed=(Window,Worker,Worklet)] declaration to the ReadableStreamDefaultController WebIDL file as it was added in a new version of the Streams spec, based on whatwg/streams#963. Intent To Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/yZuxrW9zhAs/m/6bXDaW2mAwAJ Bug: 1093862 Change-Id: I2bd0c759d856c176037231adbe7e679ccea945c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570755 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#837841}
Configuration menu - View commit details
-
Copy full SHA for 794b4cc - Browse repository at this point
Copy the full SHA 794b4ccView commit details -
Remove :active on blur for checkable inputs
Before this patch, <input type=checkbox> and <input type=radio> can be left in an active state if you press the spacebar down to toggle it, and then press tab to move focus away before releasing the spacebar. This patch calls SetActive(false) on the blur event for these input types, which clears the active state in this case. The test uses test_driver.Actions(), which isn't supported by the layout test runner but works just fine in the separate wpt runner in the wpt github repo. I wrote the test and verified that it works well with the separate wpt test runner, then wrote a TestExpectations line against the bug to track the issue with the layout test runner: crbug.com/893480 Fixed: 1157510 Change-Id: I13a0900277dbfccc87ba81ffd684b12430665e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594107 Reviewed-by: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#837867}
Configuration menu - View commit details
-
Copy full SHA for 469baec - Browse repository at this point
Copy the full SHA 469baecView commit details -
Update interfaces/webxr-hand-input.idl (web-platform-tests#26937)
Configuration menu - View commit details
-
Copy full SHA for 14e5eb0 - Browse repository at this point
Copy the full SHA 14e5eb0View commit details -
Treat mmultiscripts with two <mprescripts> children as invalid
Per [1], mmultiscripts can only have one in-flow <mprescripts/> child so this CL fixes IsValidMultiscript() to align with the specification. It also makes similar adjustment for the corresponding fatal checks in NGMathScriptsLayoutAlgorithm::GatherChildren (rather than just checking the index of a previous <mprescripts> is nonzero, which does not work if there is no post-scripts). This fixes an assertion about node not being laid out due to the fact that the mmultiscripts algorithm only performs layout of at most one <mprescript>. [1] https://mathml-refresh.github.io/mathml-core/#prescripts-and-tensor-indices-mmultiscripts Bug: 1158375, 6606 Change-Id: I26964b2ef287585392db7f1854251b4b21075aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593643 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#837987}
Configuration menu - View commit details
-
Copy full SHA for 3ceff73 - Browse repository at this point
Copy the full SHA 3ceff73View commit details -
Ensure we set environment variables when running wdspec tests
wdspec launches Firefox using geckodriver. This was going through a different codepath to the other wpt tests and in particular it wasn't setting the correct environment variables. This patch factors the environment variable setting out into a function that can be called both when starting Firefox normally and before invoking pytest. This isn't perfect, but does allow more code sharing between the two paths. Differential Revision: https://phabricator.services.mozilla.com/D97490 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1678044 gecko-commit: c4756cf7f5f109cfd552399a3fe14694ce91de11 gecko-reviewers: maja_zf
Configuration menu - View commit details
-
Copy full SHA for 9b8ff7e - Browse repository at this point
Copy the full SHA 9b8ff7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5adb165 - Browse repository at this point
Copy the full SHA 5adb165View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e580e4 - Browse repository at this point
Copy the full SHA 1e580e4View commit details -
python3 - testing/web-platform/tests - base64.decodestring -> base64.…
…decodebytes. Differential Revision: https://phabricator.services.mozilla.com/D98960 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1681101 gecko-commit: dd50d2d0bf6290c464701bbdf428cfdc3f151a05 gecko-reviewers: webdriver-reviewers, jgraham
Configuration menu - View commit details
-
Copy full SHA for 056a2f9 - Browse repository at this point
Copy the full SHA 056a2f9View commit details -
Fire capture before bubble handlers at target
Before this patch, event handlers registered at the target of the event, which get fired during the AT_TARGET event phase, get fired in order of when they are registered without any regard for which handlers are capture and which ones are bubble. This patch fires all capture handlers before bubble handlers during the AT_TARGET event phase. WebKit implemented the same behavior here: https://trac.webkit.org/changeset/236002/webkit I2S: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/blink-dev/30jv38uD_84 Fixed: 1052152 Change-Id: I87752225dbcef7d07fccf9a6999711bdf5fbad20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581814 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#838108}
Configuration menu - View commit details
-
Copy full SHA for eafd352 - Browse repository at this point
Copy the full SHA eafd352View commit details -
Cannot balance columns based on overflow block-size.
Replace TODO with comment. If the inline-size of the contents of the multicol container is 0, an empty overflow rectangle will be produced, even if block-size is non-zero, and we'd fail balancing of blocks that are freely breakable inside, if initial column block-size is 0. The space shortage reporting machinery (which is what we use in subsequent column layout passes) really only works for content that we cannot (or at least don't want to) break inside. We'd also get log2(N)-ish relayouts (where N is the total block-size of the contents). So it looks like we need to keep CalculateColumnContentBlockSize(), after all. I tried to get rid of it here, before I realized that it would cause trouble: https://chromium-review.googlesource.com/c/chromium/src/+/2597308 Add a test that demonstrates this. Note that external/wpt/css/css-multicol/baseline-006.html also tests this, but that's not the main point with that test. Bug: 829028 Change-Id: I24516a5956f9e60f47c87cf51db2683feded1eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595540 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#838116}
Configuration menu - View commit details
-
Copy full SHA for f70ab3a - Browse repository at this point
Copy the full SHA f70ab3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bb3b1d - Browse repository at this point
Copy the full SHA 7bb3b1dView commit details -
URLPattern: Remove WPT cases with poor URL interop.
Kenneth Christiansen ran into a few interop issues while trying to get his polyfill implementation to pass the WPT tests. In particular, it seems browsers and nodejs do not agree on hostnames with characters like '|', '^', etc. This CL removes these test cases for now. Solving URL interop issues is outside of the scope of URLPattern. It simply builds on top of the platforms existing URL canonicalization behavior. Kenneth also suggested testing a protocol with a dash in it. Bug: 1141510 Change-Id: I5bdf75b93545dd59592d6be9c7870f4367f7b0dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596113 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#838172}
Configuration menu - View commit details
-
Copy full SHA for a70aff0 - Browse repository at this point
Copy the full SHA a70aff0View commit details -
Prevent contenteditable anchors from being stuck :active
Without this patch, anchors can be stuck in the :active state if contenteditable is enabled before :active is removed. The special logic for anchors and contenteditable was added a long time ago [1], and the purpose was to prevent anchors from being clicked and navigating the page while in contenteditable. This patch makes SetActive capable of removing :active during contenteditable, which preserves the original intention of preventing anchors from navigating during contenteditable. [1] http://crrev.com/1d651243ad5b85bac9ebc8611a991a23d72d2f95 Fixed: 1007941 Change-Id: Ib51b846e99fd212a478f1278b3568bda4e5886a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595978 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#838208}
Configuration menu - View commit details
-
Copy full SHA for 04c64f1 - Browse repository at this point
Copy the full SHA 04c64f1View commit details -
Cache theming values from nsTextControlFrame correctly.
The issue is that nsTextControlFrame might have a different used padding then the editing root block and thus the editing root's scrolled content, etc, because its padding doesn't match the style. This causes TextOverflow code to miscompute the content area size, which is sadness and causes the overflow markers to go over the padding box. The REFLOW_ROOT condition was introduced in bug 157846 and only partially takes care of the issue. This fix supersedes it, so we can remove it. Differential Revision: https://phabricator.services.mozilla.com/D99838 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1577530 gecko-commit: fd07538e12316562b6479e77af02c7b2b0f94d43 gecko-reviewers: heycam
Configuration menu - View commit details
-
Copy full SHA for 653a45a - Browse repository at this point
Copy the full SHA 653a45aView commit details -
Remove the test since some themes seem to do weird stuff when padding…
… is specified, and this is covered once non-native-theme is enabled. MANUAL PUSH: Remove just-introduced orange test CLOSED TREE bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1577530 gecko-commit: 5ef9fa2708b2ba34de8a3674b328476fdf92908c
Configuration menu - View commit details
-
Copy full SHA for 1c85dc1 - Browse repository at this point
Copy the full SHA 1c85dc1View commit details -
P2. Add a WPT to verify the referrer header is sent correctly
Depends on D99358 Differential Revision: https://phabricator.services.mozilla.com/D99359 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1678545 gecko-commit: 2246b7b99f0f334084ae8898d433c75234f23aa5 gecko-reviewers: ckerschb
Configuration menu - View commit details
-
Copy full SHA for 2b6357b - Browse repository at this point
Copy the full SHA 2b6357bView commit details -
blink: adds test for overflow-clip-margin and intersection observer
This verifies intersection observer properly reflects overflow-clip-margin on an ancestor. BUG=1157843 TEST=test only change Change-Id: I9c9839294df8ffb88b42947aa87c7cc5222f5a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593812 Reviewed-by: Stefan Zager <szager@chromium.org> Reviewed-by: vmpstr <vmpstr@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#838232}
Configuration menu - View commit details
-
Copy full SHA for 7e7eb27 - Browse repository at this point
Copy the full SHA 7e7eb27View commit details -
Add sessionHistoryInParent value for test manifests.
Differential Revision: https://phabricator.services.mozilla.com/D99666 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1668658 gecko-commit: d935544227af3d68a19eae4d11d9765b56062be3 gecko-reviewers: smaug, jgraham
Configuration menu - View commit details
-
Copy full SHA for 0aa080a - Browse repository at this point
Copy the full SHA 0aa080aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e1c13d5 - Browse repository at this point
Copy the full SHA e1c13d5View commit details -
Simulate user inputs in focus-visible tests in css/selectors/
Use testdriver Action API to simulate mouse actions in css/selectors/focus-visible-006.html and css/selectors/focus-visible-008.html. Bug: 1145677 Change-Id: Id25c6120f1dbd489d4c803ee979e67ad5ef49f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551818 Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#838271}
Configuration menu - View commit details
-
Copy full SHA for 851d338 - Browse repository at this point
Copy the full SHA 851d338View commit details
Commits on Dec 18, 2020
-
Make <script type="module"> attribute check case-insensitive
This CL makes Chromium to align with the spec and other browsers (Firefox/Safari). Bug: 1160101 Change-Id: I30e38acc8cfe80781eb68bf602938362aafc1f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597755 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#838358}
Configuration menu - View commit details
-
Copy full SHA for 83e9daa - Browse repository at this point
Copy the full SHA 83e9daaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 613325f - Browse repository at this point
Copy the full SHA 613325fView commit details -
Fix infra failure on Android WPT waterfall
This is a quick fix for the wpt import from upstream: https://chromium-review.googlesource.com/c/chromium/src/+/2595735 Bug: 1159946 Change-Id: Ie72dd6135ab6b6d6f6505a93eda4a2a4c58e1f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597043 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#838393}
Configuration menu - View commit details
-
Copy full SHA for 43dc4d2 - Browse repository at this point
Copy the full SHA 43dc4d2View commit details -
Don't clip SVG mask bounding box with content visual rect
We can't clip with a proper visual rect that includes effects from filters during pre-paint, because filters may not have been updated yet. Since the visual rect no longer include bounds from filters, clipping to them is too restrictive. Drop said clipping from LayoutSVGResourceMasker::ResourceBoundingBox(). This in turn means that the |mask_content_boundaries_| member field as well as the code to compute it is dead, so remove them as well. Bug: 1153600 Change-Id: I633deccba1a841750b4ef920725b59526b9846e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566822 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#838440}
Configuration menu - View commit details
-
Copy full SHA for 3db2ee0 - Browse repository at this point
Copy the full SHA 3db2ee0View commit details -
Support shorthand filter functions on SVG elements
This enables the full 'filter' property syntax on SVG elements. Since SVG elements expect effects of zoom to be included in their local transform, we have to take care to undo zoom from any Length parameters when building the filter chain. Bug: 109224 Change-Id: Ib7f6050f57cc2723d1396f05424da788df675188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595416 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#838451}
Configuration menu - View commit details
-
Copy full SHA for af4ee66 - Browse repository at this point
Copy the full SHA af4ee66View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab6f4e2 - Browse repository at this point
Copy the full SHA ab6f4e2View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 060ac60 - Browse repository at this point
Copy the full SHA 060ac60View commit details -
[LayoutNG] Multi-column containing blocks
Currently, when a multi-column is a containing block for an OOF positioned element, the corresponding column is mistaken for the containing block, which causes various DCHECK failures. Columns are not allowed to be containing blocks, so this change ensures that we skip over columns when placing OOF positioned elements. Bug: 1158706 Change-Id: Id969b91a8f472d34b4767ffe891a3405770e8443
1Configuration menu - View commit details
-
Copy full SHA for 4b19550 - Browse repository at this point
Copy the full SHA 4b19550View commit details -
[LayoutNG] Clean-up out-of-flow-in-multi-column WPT
Once upon a time, we created a WPT for OOFs in multi-columns - with a tiny harmless nit that swooped in at the last second. Since then, we created a bunch of similar tests by copying the initial test and duplicating the nit every time in every test. This CL cleans up that nit in every test I could find it. Bug: N/A Change-Id: I19a53bca22719f8f0193d02bf94d13700a1e823d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598541 Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#838487}
1Configuration menu - View commit details
-
Copy full SHA for 96bc64e - Browse repository at this point
Copy the full SHA 96bc64eView commit details
Commits on Dec 19, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 132850c - Browse repository at this point
Copy the full SHA 132850cView commit details
Commits on Dec 21, 2020
-
Update Interface Object test expectations for Exposed Streams interfaces
Following https://chromium-review.googlesource.com/c/chromium/src/+/2570755, this CL updates the interface object WPT expectations to remove Streams API interface classes that have already been exposed. Bug: 1093862 Change-Id: Ibdce3585a8b34b3aeef40e3fae610af733ebdc79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595553 Reviewed-by: Adam Rice <ricea@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#838599}
Configuration menu - View commit details
-
Copy full SHA for c00d2d2 - Browse repository at this point
Copy the full SHA c00d2d2View commit details -
Part 3 - Use zero percentage basis to compute specified size suggesti…
…on for compressible flex items. Also, add test for various types of <input> in row flex containers (flex-item-compressible-001.html) and in column flex containers (flex-item-compressible-002.html). Note: Google Chrome 89 and Safari 14 fail the subtests that have a definite value inside a calc expression in flex-item-compressible-001.html. They also fail the entire flex-item-compressible-002.html because they don't support <input> in vertical writing-mode (i.e. <input> is still horizontal in vertical writing mode). Differential Revision: https://phabricator.services.mozilla.com/D99952 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1585485 gecko-commit: a605cd5254503b3de8827ce2789abd6e60292018 gecko-reviewers: dholbert
Configuration menu - View commit details
-
Copy full SHA for c0ee96e - Browse repository at this point
Copy the full SHA c0ee96eView commit details -
[WPT] Add a test for terminating a worker during top-level await
Bug: 1022182 Change-Id: I98d3897fdc99d42a0b6bb09461bfb228068ddd02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586206 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#838619}
Configuration menu - View commit details
-
Copy full SHA for 56e6f63 - Browse repository at this point
Copy the full SHA 56e6f63View commit details -
Revert "Simulate user inputs in focus-visible tests in css/selectors/"
This reverts commit 9d0120f3d75be146445be64e770063d03f3049c7. Reason for revert: Very close to 100% failure rate since check-in, on bot "WebKit Linux Leak": https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/21884 Error message: Retrying 19 unexpected failures, attempt 1 of 3... Sharding tests ... Starting 8 workers ... [18/19] external/wpt/css/selectors/focus-visible-006.html failed unexpectedly (leak detected: ({"numberOfLiveContextLifecycleStateObservers":[2,4],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,40],"numberOfLiveResourceFetchers":[1,2],"numberOfLiveResources":[0,5]})) stopping content_shell(pid 14917) timed out, killing it [19/19] external/wpt/referrer-policy/gen/worker-classic.http-rp/strict-origin-when-cross-origin/worker-classic.http.html failed unexpectedly (test timed out) Original change's description: > Simulate user inputs in focus-visible tests in css/selectors/ > > Use testdriver Action API to simulate mouse actions in > css/selectors/focus-visible-006.html and > css/selectors/focus-visible-008.html. > > Bug: 1145677 > Change-Id: Id25c6120f1dbd489d4c803ee979e67ad5ef49f8c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551818 > Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838271} TBR=lanwei@chromium.org,mustaq@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1145677 Change-Id: Ie2e39aa960a80dd0ab5b9ec881ae9305c4294760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599530 Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#838637}
1Configuration menu - View commit details
-
Copy full SHA for 71ae75d - Browse repository at this point
Copy the full SHA 71ae75dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a1a98c - Browse repository at this point
Copy the full SHA 1a1a98cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3aa0a78 - Browse repository at this point
Copy the full SHA 3aa0a78View commit details -
use document URI rather than baseURI for local references with SMIL
Differential Revision: https://phabricator.services.mozilla.com/D100207 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1682307 gecko-commit: 079ae6e08d0d77fbf369751b0f823f530c396b60 gecko-reviewers: emilio
Configuration menu - View commit details
-
Copy full SHA for bea954a - Browse repository at this point
Copy the full SHA bea954aView commit details -
Don't try to set the environment for firefox_android
This doesn't make sense since tests are running on the device, not locally. Differential Revision: https://phabricator.services.mozilla.com/D99246 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1678663 gecko-commit: c9931fc09331f62ca4e8a1d8fb3ceb7e619799ea gecko-reviewers: karlcow
Configuration menu - View commit details
-
Copy full SHA for 5c5e74e - Browse repository at this point
Copy the full SHA 5c5e74eView commit details -
Support passing adb binary in to wptrunner
Differential Revision: https://phabricator.services.mozilla.com/D99254 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1678663 gecko-commit: c584e6f853e63362b9aa8406554db7e5ec344683 gecko-reviewers: bc
Configuration menu - View commit details
-
Copy full SHA for 67f439f - Browse repository at this point
Copy the full SHA 67f439fView commit details -
Fix rather broken handling of errors during setup
Differential Revision: https://phabricator.services.mozilla.com/D99255 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1678663 gecko-commit: 4fbd1c323b6d59414c56fcc1fa958639ea4b5243 gecko-reviewers: karlcow
Configuration menu - View commit details
-
Copy full SHA for 24e467a - Browse repository at this point
Copy the full SHA 24e467aView commit details -
Change wptrunner multiprocessing start method to spawn
This makes Linux match Windows and macOS, and avoids a py3-only bug where mozrunner desctructors can end up being called incorrectly in the child process, so causing tests to fail. To do this correctly turns out to require using an explicit context which we pass down to everywhere we use multiprocessing. That's because wptrunner isn't usually invoked directly but from a frontend like `wpt run` or `mach`. Therefore spawned processed don't go through the same entrypoint as the initial process and so don't set the context themselves. This unfortunately requires backwards-incompatible changes in mozlog, so that will need to be released for this to land upstream. Differential Revision: https://phabricator.services.mozilla.com/D99247 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1678663 gecko-commit: 38d6e1fcab14e49dbdb2c0953542f33ec259b740 gecko-reviewers: karlcow, bc
Configuration menu - View commit details
-
Copy full SHA for b0fa649 - Browse repository at this point
Copy the full SHA b0fa649View commit details -
Allow mozrunner.Runner instances to avoid cleanup in __del
The change in behaviour of the gc in Python 3 means that __del__ is being called in cases where it previously wasn't, and this can have unfortunate side effects where __del__ is being used to clean up resources. In particular with web-platform-tests running on Android, we end up closing the test application unexpectedly. That causes widespread test failures. In general using __del__ for this kind of cleanup is problematic because it's not defined exactly when, or if, it's called. It's much better to require explcit cleanup (and better still to make that scope-based, using a context manager, although this patch doesn't do so). Therefore we add an option to only do explicit cleanup. This is currently opt-in to make the breakage as small as possible, but ultimately ought to be the default and only behaviour. We also change the wpt android runner to use this behaviour. Differential Revision: https://phabricator.services.mozilla.com/D99256 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1678663 gecko-commit: 4a753391c683c7a470182558c1384414daec8aca gecko-reviewers: whimboo
Configuration menu - View commit details
-
Copy full SHA for f3a4bca - Browse repository at this point
Copy the full SHA f3a4bcaView commit details -
Fix stash unittests with multiprocessing.spawn
The problem was that classes defined in functions can't be recreated in child processes. So we need to make the classes global instead. Differential Revision: https://phabricator.services.mozilla.com/D99250 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1678663 gecko-commit: 3ab9b82d7122fc10b37d0fb68252e1440629ca99 gecko-reviewers: karlcow
Configuration menu - View commit details
-
Copy full SHA for e1873c1 - Browse repository at this point
Copy the full SHA e1873c1View commit details -
Add long timeout to test that times out on win 7 opt in py3
This test was previously stable but seems to run a litle slower in Python 3 so we see some timeouts. Make the timeout longer so avoid the failure. Differential Revision: https://phabricator.services.mozilla.com/D99435 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1678663 gecko-commit: 4967a4a57ab2a658e026e09d6b363876a9018831 gecko-reviewers: karlcow
Configuration menu - View commit details
-
Copy full SHA for d9d921b - Browse repository at this point
Copy the full SHA d9d921bView commit details -
Pass multiprocessing context in when starting server
Differential Revision: https://phabricator.services.mozilla.com/D99881 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1678663 gecko-commit: 4d41b11ea020d4b4bf697fa62dd48cf6f4920463 gecko-reviewers: emilio
Configuration menu - View commit details
-
Copy full SHA for 3519395 - Browse repository at this point
Copy the full SHA 3519395View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c3a268 - Browse repository at this point
Copy the full SHA 2c3a268View commit details -
Synchronously raise window when window.focus() called in OOP iframe
Differential Revision: https://phabricator.services.mozilla.com/D96184 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1674743 gecko-commit: 17658a2394cf21d332184a5f78f8dec6637c8a4d gecko-reviewers: hsivonen
Configuration menu - View commit details
-
Copy full SHA for 463a49f - Browse repository at this point
Copy the full SHA 463a49fView commit details -
Do not bounce IPC message to framer if focus is handled synchronously…
… in OOP iframe This suppress unnecessary blur and focus actions in the framer, we would need to find a way to notify framer that the focus has moved to OOP iframe to dispatch corresponding blur event, see bug 1677474. Differential Revision: https://phabricator.services.mozilla.com/D97158 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1674702 gecko-commit: 15ceb99908caea1e4a0d82113fc08a7ef23d976d gecko-reviewers: hsivonen
1Configuration menu - View commit details
-
Copy full SHA for 274102b - Browse repository at this point
Copy the full SHA 274102bView commit details -
Fix documentation build for python 3 (web-platform-tests#26979)
The shell script runs a python line that uses an old-style print, so it broke (silently!) when we switched to python3.
1Configuration menu - View commit details
-
Copy full SHA for 9a9734e - Browse repository at this point
Copy the full SHA 9a9734eView commit details -
Add/Fix META.yml files to ease specs to WPT mapping (web-platform-tes…
…ts#26970) This commit fixes `spec` entries in `META.yml` files that were pointing to the wrong URL (either because the URL is a broken link, redirects to a newer URL, or targets the GitHub repository instead of the spec itself), so that it becomes easier to map specifications to WPT folders based on the URL of their Editor/Living Draft. This commit also adds several `META.yml` files to folders that cannot easily be mapped to a spec because their name does not match the spec's shortname.
Configuration menu - View commit details
-
Copy full SHA for d3d67f3 - Browse repository at this point
Copy the full SHA d3d67f3View commit details
Commits on Dec 22, 2020
-
Determine the non-hangable run end when soft-hyphen is disabled
Since r807457 we changed the TextBreakIterator default's behavior so that it breaks always after a space, instead of before any space run. In order to implement this new behavior, we needed to compute as well the end of the non-hangable run of the Item being processed. In the mentioned change, we forgot to apply this behavior in the code path used when the soft-hypenation is not enabled. This CL fixes that by determining the non-hangable run end in that case. Bug: 1158747 Change-Id: I1a1324b3d775c24e44aa29b097c45e626d0ad76f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597581 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#838749}
Configuration menu - View commit details
-
Copy full SHA for ec7d216 - Browse repository at this point
Copy the full SHA ec7d216View commit details -
Reland "Simulate user inputs in focus-visible tests in css/selectors/"
Use testdriver Action API to simulate mouse actions in css/selectors/focus-visible-006.html and css/selectors/focus-visible-008.html. TBR=lanwei@chromium.org,mustaq@chromium.org Bug: 1145677 Change-Id: I41347fbe7a1fc2c1d88c548b0f2f6ef86ee75154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600018 Reviewed-by: Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#838751}
Configuration menu - View commit details
-
Copy full SHA for 9a1a27e - Browse repository at this point
Copy the full SHA 9a1a27eView commit details -
[wpt] tests were failing because of font aliasing
7 wpt tests were failing because of font aliasing in most browsers. See https://wpt.fyi/results/css/CSS2/tables?label=experimental&label=master&aligned fixed-table-layout-017/023 Switching the font to Ahem eliminated antialiasing, and makes test pass. Ahem font made some text too wide for containing cell. I've shortened the text when this happened. Change-Id: I754444e8f5f9105958642361bc4cd758f92e635f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600621 Auto-Submit: Aleks Totic <atotic@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#838825}
Configuration menu - View commit details
-
Copy full SHA for 0118373 - Browse repository at this point
Copy the full SHA 0118373View commit details -
Add further META.yml files to ease specs to WPT mapping (web-platform…
…-tests#26983) Adds META.yml files with `spec` entries to folders that could only be associated with specifications by comparing the folder's name with the spec's shortname.
Configuration menu - View commit details
-
Copy full SHA for a387de6 - Browse repository at this point
Copy the full SHA a387de6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77a8f5a - Browse repository at this point
Copy the full SHA 77a8f5aView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 0cc100d - Browse repository at this point
Copy the full SHA 0cc100dView commit details -
Re-disable stash tests when using spawn-based multiprocessing
The supposed fix didn't actually fix them in that case. We didn't notice because it didn't actually change the behaviour of the code on Linux where they pass either way.
Configuration menu - View commit details
-
Copy full SHA for a9a92ee - Browse repository at this point
Copy the full SHA a9a92eeView commit details -
Pass around the default multiprocessing context rather than a module
The API is a subset but (ironically) we can't pickle a module
Configuration menu - View commit details
-
Copy full SHA for 251274f - Browse repository at this point
Copy the full SHA 251274fView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for ae4e661 - Browse repository at this point
Copy the full SHA ae4e661View commit details -
[Document Policy] Add SyncXHR to document policy
This CL adds feature SyncXHR to document policy. It will be controlled by both document policy and feature policy during the migration period, i.e. If either policy disabled the feature, the feature will be disabled. Bug: 1146505 Change-Id: I2a2d776da13be9f659bc0369fb5a19a94f5c18ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523440 Reviewed-by: Ian Clelland <iclelland@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#838966}
Configuration menu - View commit details
-
Copy full SHA for b838db7 - Browse repository at this point
Copy the full SHA b838db7View commit details -
Fix several crashes when nested slots are removed from a ShadowRoot
There were some crashes caused by nested slots (e.g. <slot><slot>Content</slot></slot>) being removed from the tree. These crashes were triggered by [1], which removed Shadow DOM v0, but my theory is that due to the old V0 shadow root code, more calls were being made to SlotAssignment::RecalcAssignment(). Now that the V0 code is gone, it has exposed some missing code. Three issues are being fixed here: 1. In Node::CheckSlotChange(), while removing the inner nested slot, the parent_slot will have already been removed from the tree, so we only need to call DidSlotChange if not. This used to be a DCHECK. 2. In TreeOrderedMap::Get(), while removing a key that previously had more than one element, we may walk the tree and find that none of the pre-existing elements are present. I.e. we're in a RemoveScope. In this case, the key should be removed from the map. 3. In SlotAssignment::DidRemoveSlotInternal(), given web-platform-tests#2 above, we can just early-out if the slot isn't present in the map. I added a test for the crash conditions (variations on removing nested named and unnamed slots), plus I added a test for the TreeOrderedMap class, since there was none previously. The last test in the set documents the new Get() behavior. I also tried to improve some of the comments along the way. Finally, this CL rolls back a mitigation [2] previously landed for this crash. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2586019 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2595967 Bug: 1159328, 1159727 Change-Id: I47fbf33b2313b9ae2efe229443af6e8c9a1920a9 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597040 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by: Yu Han <yuzhehan@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#838974}
Configuration menu - View commit details
-
Copy full SHA for f5e7e1f - Browse repository at this point
Copy the full SHA f5e7e1fView commit details
Commits on Dec 23, 2020
-
Detect selection changes through the setters
Differential Revision: https://phabricator.services.mozilla.com/D99291 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1681615 gecko-commit: 2a7e04756c232eb775140500ef2d370fa608eb50 gecko-reviewers: masayuki
Configuration menu - View commit details
-
Copy full SHA for 58cdcda - Browse repository at this point
Copy the full SHA 58cdcdaView commit details -
Parse only the final SameSite attribute when mutliple are present
Differential Revision: https://phabricator.services.mozilla.com/D99740 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1682450 gecko-commit: c4a59b084d7b4c96d5e1ea02e6adb5774b07d6c9 gecko-reviewers: baku
Configuration menu - View commit details
-
Copy full SHA for b9e7b38 - Browse repository at this point
Copy the full SHA b9e7b38View commit details -
Clear cached path when reframed.
The issue here is caused (a bit surprisingly) by the counter-reset declaration. The underlying issue is that counter-reset causes us to rebuild the frame tree for the whole `<body>`, in order to rebuild the counter tree. That makes the geometry frame not get its updated style (because the frame goes away), and the next frame getting constructed getting a null aOldComputedStyle (as expected, as it's a new frame). We can't rely on the cached path not to change while there's no frame, so clear it out when there's no old style. The test is a simpler version of the test-case, where instead of `counter-reset`, I use `display: none` to trigger the bogus codepath. Differential Revision: https://phabricator.services.mozilla.com/D100237 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1683652 gecko-commit: c38b504a94295b09dce13d91e04ff9714b0eb67b gecko-reviewers: longsonr
Configuration menu - View commit details
-
Copy full SHA for e5a6179 - Browse repository at this point
Copy the full SHA e5a6179View commit details -
Revert "Fix several crashes when nested slots are removed from a Shad…
…owRoot" This reverts commit dbfed21f94881a2918223792ebde3476b8fd69e6. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 838974 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2RiZmVkMjFmOTQ4ODFhMjkxODIyMzc5MmViZGUzNDc2YjhmZDY5ZTYM Sample Failed Build: https://ci.chromium.org/b/8860163671563368608 Sample Failed Step: webkit_unit_tests Original change's description: > Fix several crashes when nested slots are removed from a ShadowRoot > > There were some crashes caused by nested slots (e.g. > <slot><slot>Content</slot></slot>) being removed from the tree. > These crashes were triggered by [1], which removed Shadow DOM v0, but > my theory is that due to the old V0 shadow root code, more calls were > being made to SlotAssignment::RecalcAssignment(). Now that the V0 code > is gone, it has exposed some missing code. > > Three issues are being fixed here: > 1. In Node::CheckSlotChange(), while removing the inner nested slot, > the parent_slot will have already been removed from the tree, so we > only need to call DidSlotChange if not. This used to be a DCHECK. > 2. In TreeOrderedMap::Get(), while removing a key that previously had > more than one element, we may walk the tree and find that none of > the pre-existing elements are present. I.e. we're in a RemoveScope. > In this case, the key should be removed from the map. > 3. In SlotAssignment::DidRemoveSlotInternal(), given web-platform-tests#2 above, we can > just early-out if the slot isn't present in the map. > > I added a test for the crash conditions (variations on removing nested > named and unnamed slots), plus I added a test for the TreeOrderedMap > class, since there was none previously. The last test in the set > documents the new Get() behavior. I also tried to improve some of the > comments along the way. Finally, this CL rolls back a mitigation [2] > previously landed for this crash. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/2586019 > [2] https://chromium-review.googlesource.com/c/chromium/src/+/2595967 > > Bug: 1159328, 1159727 > Change-Id: I47fbf33b2313b9ae2efe229443af6e8c9a1920a9 > Cq-Do-Not-Cancel-Tryjobs: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597040 > Commit-Queue: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Yu Han <yuzhehan@chromium.org> > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Auto-Submit: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838974} Change-Id: I97202c545f74df090124e82775fe79ce978d3d63 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1159328, 1159727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601758 Cr-Commit-Position: refs/heads/master@{#839038}
Configuration menu - View commit details
-
Copy full SHA for 1c5816e - Browse repository at this point
Copy the full SHA 1c5816eView commit details -
Fix the first subtest in flexbox-min-height-auto-002b.html.
Before this patch, in the first subtest, the image flex item's final width is 104px. This is because the floating flex container uses shrink-wrapping to obtain its inline-size, and the flex item's min-content contribution to the flex container is 104px (100px height * 1/1 aspect-ratio + 4px border). That makes the single-line flex container's final cross-size 104px, stretching the item's cross size to the flex container's cross size. This test is meant to test min-height:auto behavior, so this patch adds a constraint to the flex container's cross size so that the flex item's cross size (width) won't get stretched. Differential Revision: https://phabricator.services.mozilla.com/D100302 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1670830 gecko-commit: 83c08ef3251b25cb4322e800cddeb53d7c9ee0e0 gecko-reviewers: dholbert
Configuration menu - View commit details
-
Copy full SHA for 91129af - Browse repository at this point
Copy the full SHA 91129afView commit details -
Target additional specs in META.yml files (web-platform-tests#26997)
This brings in the following updates to better associate folders with specs: - document-policy => link to Document Policy spec - html/cross-origin-embedder-policy => proposal was integrated into HTML spec - html/cross-origin-opener-policy => proposal was integrated into HTML spec - installedapps => link to Get Installed Related Apps API - js => update URL to use tc39.es domain name - measure-memory => link to Measure Memory API - native-file-system => link to File System Access - screen_enumartion => link to Multi-Screen Window Placement spec - webrtc-extensions => fix broken link - x-frame-options => target multipage version (consistent with other folders)
Configuration menu - View commit details
-
Copy full SHA for 38baeea - Browse repository at this point
Copy the full SHA 38baeeaView commit details -
Fix ref link in css/css-backgrounds/box-shadow-radius-000.html
box-shadow-radius-001-ref.html -> box-shadow-radius-000-ref.html Bug: 1159514 Change-Id: I3611c3bf85143b038da652c4f28e66d2378439a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600693 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#839103}
Configuration menu - View commit details
-
Copy full SHA for b141626 - Browse repository at this point
Copy the full SHA b141626View commit details -
Update interfaces/encrypted-media.idl (web-platform-tests#26992)
Configuration menu - View commit details
-
Copy full SHA for b4be9a3 - Browse repository at this point
Copy the full SHA b4be9a3View commit details -
Reland "Fix several crashes when nested slots are removed from a Shad…
…owRoot" This is a reland of dbfed21f94881a2918223792ebde3476b8fd69e6 --> Patchset 2 contains the fix, just a missing initializer on an int in the test. Original change's description: > Fix several crashes when nested slots are removed from a ShadowRoot > > There were some crashes caused by nested slots (e.g. > <slot><slot>Content</slot></slot>) being removed from the tree. > These crashes were triggered by [1], which removed Shadow DOM v0, but > my theory is that due to the old V0 shadow root code, more calls were > being made to SlotAssignment::RecalcAssignment(). Now that the V0 code > is gone, it has exposed some missing code. > > Three issues are being fixed here: > 1. In Node::CheckSlotChange(), while removing the inner nested slot, > the parent_slot will have already been removed from the tree, so we > only need to call DidSlotChange if not. This used to be a DCHECK. > 2. In TreeOrderedMap::Get(), while removing a key that previously had > more than one element, we may walk the tree and find that none of > the pre-existing elements are present. I.e. we're in a RemoveScope. > In this case, the key should be removed from the map. > 3. In SlotAssignment::DidRemoveSlotInternal(), given web-platform-tests#2 above, we can > just early-out if the slot isn't present in the map. > > I added a test for the crash conditions (variations on removing nested > named and unnamed slots), plus I added a test for the TreeOrderedMap > class, since there was none previously. The last test in the set > documents the new Get() behavior. I also tried to improve some of the > comments along the way. Finally, this CL rolls back a mitigation [2] > previously landed for this crash. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/2586019 > [2] https://chromium-review.googlesource.com/c/chromium/src/+/2595967 > > Bug: 1159328, 1159727 > Change-Id: I47fbf33b2313b9ae2efe229443af6e8c9a1920a9 > Cq-Do-Not-Cancel-Tryjobs: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597040 > Commit-Queue: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Yu Han <yuzhehan@chromium.org> > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Auto-Submit: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838974} Bug: 1159328 Bug: 1159727 Change-Id: I0025c0f00d6b3876de8f40a60fdc34f726ddc85c Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601051 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#839148}
Configuration menu - View commit details
-
Copy full SHA for 0fa6dc5 - Browse repository at this point
Copy the full SHA 0fa6dc5View commit details -
This is required by the vendored pytest, but was missed in PR 26704. The vendoring is done simply by extracting the source package into the third_party directory. Differential Revision: https://phabricator.services.mozilla.com/D100238 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1683639 gecko-commit: 07a16a5ecab94c6a7e862742ad85c9eb416d4a2b gecko-reviewers: whimboo
Configuration menu - View commit details
-
Copy full SHA for 9d6a7a5 - Browse repository at this point
Copy the full SHA 9d6a7a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e32839 - Browse repository at this point
Copy the full SHA 8e32839View commit details -
Fix duplicate id in declarative Shadow DOM test
The same id was used twice, whereas they should have been unique. No behavior changes, just a cleanup, so TBR: TBR=masonfreed@chromium.org Bug: 1042130 Change-Id: I58e4acc00acabbb728c730fe3910aea65c4c11e1 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601052 Reviewed-by: Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#839198}
1Configuration menu - View commit details
-
Copy full SHA for ec1a688 - Browse repository at this point
Copy the full SHA ec1a688View commit details
Commits on Dec 24, 2020
-
Fix serialization for <noscript> contents when script is disabled
Previous to this CL, serialization for <noscript> nodes in a document with (per spec) no execution context would still *not* escape (e.g. '<' --> '<') the contents. This allowed a sanitizer bypass. I added a fairly comprehensive test of the many fragment parser entry points here. Before this CL (and on other browsers): - Chrome would never escape <noscript> contents. (This bug) - Firefox would never escape <noscript> contents. (Should raise a bug) - Safari *always* escapes <noscript> contents, *even* when it shouldn't, such as with div.innerHTML, div.insertAdjacentHTML, and document.write on the main document. (Should raise a bug) An additional set of differences showed up for the *parsing* escaping behavior: - Chrome would (and still does) de-escape <noscript> contents when parsing in a script-disabled context, such as DOMParser or createHTMLDocument.innerHTML. It does *not* de-escape <noscript> contents in script-enabled contexts, such as div.innerHTML and document.write. This all seems correct to me. - Safari behaves identically to Chrome here (correct). - Firefox de-escapes <noscript> contents in some cases (e.g. XMLHTTPRequest, document.write) but not others (e.g. template.innerHTML, createHTMLDocument.innerHTML, and createHTMLDocument.createContextualFragment). I looked for a spec issue, but didn't find one. If there really isn't a spec issue for this, we should raise one. Fixed: 1160635 Change-Id: I361a72409093e69b074495c475e9d647c6c58300 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602447 Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#839214}
1Configuration menu - View commit details
-
Copy full SHA for 65e6854 - Browse repository at this point
Copy the full SHA 65e6854View commit details -
Replace 'dummy' with 'sample' for inclusive language (web-platform-te…
…sts#26985) This CL just replaces 'dummy' with 'sample' in wpt/service-workers/service-worker/ and doesn't change any behaviors. https://developers.google.com/style/inclusive-documentation#ableist-language Change-Id: I95ca5e6de761412d20ee3ec5c5aebcd29e493de3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598535 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#838834} Co-authored-by: Asami Doi <asamidoi@chromium.org>
Configuration menu - View commit details
-
Copy full SHA for 2ccf303 - Browse repository at this point
Copy the full SHA 2ccf303View commit details
Commits on Dec 27, 2020
-
1
Configuration menu - View commit details
-
Copy full SHA for 9c26c9e - Browse repository at this point
Copy the full SHA 9c26c9eView commit details
Commits on Dec 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 375b1c6 - Browse repository at this point
Copy the full SHA 375b1c6View commit details -
[selectors] Improve :focus-visible tests
These tests were using "outline-style: auto" but then set an outline-color. Some browsers like Firefox ignore the outline-color when rendering the auto style, which follows the spec (https://drafts.csswg.org/css-ui/#typedef-outline-line-style): "As such, this specification does not define how the outline-color and outline-width are incorporated or used (if at all) when rendering auto style outlines." So this patch changes outline-style to "solid" in all these tests to avoid this problem. Apart from that the patch adds a condition to show the wrong behavior if the browser doesn't support :focus-visible using "@supports not (selector(:focus-visible))". That's not done for focus-visible-007.html as that test has other problems that need to be fixed in its own patch (see https://crbug.com/976438).
1Configuration menu - View commit details
-
Copy full SHA for ccaf459 - Browse repository at this point
Copy the full SHA ccaf459View commit details -
[blink] Enable ModuleScript streaming compilation
- Bail out in ScriptStreamer::TryStartStreamingTask if the response is not a JavaScript mime type (for CSS and JSON modules) - Only initiate script streaming from the main thread (for now this prevents streaming compilation for workers and worklets) - Fix trace event ending for streaming compiled module scripts - Add WPT test with a large CSS module that would previously trigger script streaming Bug: 1061857 Change-Id: I5100e4c12aa3504ea4132b344f7910041270318a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595299 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#839447}
1Configuration menu - View commit details
-
Copy full SHA for e2c77fa - Browse repository at this point
Copy the full SHA e2c77faView commit details -
Re-write wpt/cookies/http-state/ path tests
This also adds support for sending multiple Set-Cookie strings to the test infrastructure. Notes for history books (and reviewers) legacy test => ported test cookie name map (ignoring Path) path0001 => (path.html) testA=11; testB=11 path0002 => (path.html) testB=12; testA=12 path0003 => (path.html) testA=13; testB=13 path0004 => (path.html) testB=14; testA=14 path0005 => (path.html) test=15 path0006 => (path.html) test=16 path0007 => (path-redirect.html) test=1 path0008 => (path-redirect.html) test=9 path0009 => (path-redirect.html) test=10 (can be improved) path0010 => (path-redirect.html) test=2 path0011 => (path-redirect.html) test=11 path0012 => (path-redirect.html) test=12 path0013 => (path-redirect.html) test=13 path0014 => (path-redirect.html) test=17 path0015 => not ported, see note below. path0016 => (path-redirect.html) test=3 path0017 => (path-redirect.html) test=4 path0018 => (path-redirect.html) test=14 (can be improved) path0019, dupe of (path.html) test1, not ported path0020, dupe of (path.html) test2, not ported path0021, dupe of (path.html) test3, not ported path0022 => (path.html) test=17 path0023 => (path.html) test=18 path0024 => (path-redirect.html) test=15 path0025 => (path-redirect.html) test=16 path0026 => (path-redirect.html) test=5 path0027 => (path-redirect.html) test=6 path0028 => (path-redirect.html) test=7a disabled-path0029 (path-redirect.html) test=7b path0029 => (path.html) test=19 path0030 => (path.html) test=21 path0031 => path.html test=20 path0032 => (path-redirect.html) test=8a; test=8b Notes: For path0027 and path0028, I'm swapping the assertions (to expected a cookie) because Firefox, Safari and Chrome do this. path0015 isn't possible to port with current WPT infra (as there are no dynamic handlers, and '/' is treated as a directory "mount"). https://bugs.chromium.org/p/chromium/issues/detail?id=1161544 is filed to track that work, and a few improvements to better capture the intents of path0009 and path0018. Bug: 1159925 Change-Id: I37da066e60d79e3f99e01a7d6ccbc408f447e01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598139 Commit-Queue: Mike Taylor <miketaylr@chromium.org> Reviewed-by: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#839497}
1Configuration menu - View commit details
-
Copy full SHA for 821a1ef - Browse repository at this point
Copy the full SHA 821a1efView commit details
Commits on Dec 30, 2020
-
Added tests for first-letter pseudo element with preceding punctuatio…
…n and intervening spaces.
1Configuration menu - View commit details
-
Copy full SHA for e7ab505 - Browse repository at this point
Copy the full SHA e7ab505View commit details
Commits on Dec 31, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e1b2973 - Browse repository at this point
Copy the full SHA e1b2973View commit details -
Add UseBoxSizing for AspectRatio class, and fix non-replaced element …
…usage. Based on the spec, if the aspect-ratio property value is: 1) auto: we should always use content-box dimensions. 2) <ratio>: the aspect-ratio works with box sizing dimensions. 3) auto && <ratio>: we use content-box dimensions in all cases. So we need an extra flag to address that we should use box-sizing or always use content-box dimensions while computing the size in ratio-dependent axis. This also updates some wpts for non-replaced elements because we should use content-box if aspect-ratio is 'auto && <ratio>'. Differential Revision: https://phabricator.services.mozilla.com/D100072 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1683424 gecko-commit: c86f4e7967e31ea0d0bcc67ff4127ee5b125fb66 gecko-reviewers: TYLin
1Configuration menu - View commit details
-
Copy full SHA for 51f0ded - Browse repository at this point
Copy the full SHA 51f0dedView commit details -
Take box sizing into account for replaced elements with aspect-ratio.
If aspect-ratio is '<ratio>', now the aspect-ratio works with box sizing dimensions for replaced elements. Also, ComputeRatioDependentSize() already considers writing-mode so we don't need the conversion like logicalRatio in the old code. For those calculations for intrinsic size contribution, we will fix them in a separate patch. Differential Revision: https://phabricator.services.mozilla.com/D100175 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1683424 gecko-commit: 5dc148186bb2cac6b7131574ac6c518cea93baf5 gecko-reviewers: TYLin
1Configuration menu - View commit details
-
Copy full SHA for dbc7edf - Browse repository at this point
Copy the full SHA dbc7edfView commit details
Commits on Jan 2, 2021
-
This patch reverts previous instrumentation: https://chromium-review.googlesource.com/c/chromium/src/+/2402719 Two problems have been found: 1. The test expected the load event to be triggered twice. One for the initial load, then the child document navigates itself, which caused a second load event to be dispatched. The problem: the navigation might start before the load event. Those are known as "client-side" redirect. The test fails because it received only one load event. Solution is to wait for the load event to be dispatched before initiating the navigation. 2. One test was doing weird things with several navigations triggered in parallel (history.back() in the window + regular navigation). Moreover the history.back() navigation was going toward a document that navigate itself (again). Solution was to rewrite the test. Bug: 1013596 Change-Id: I1cbbbcf07a91e8beb220d688fb1e39f6559277cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584850 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#839946}
1Configuration menu - View commit details
-
Copy full SHA for 95b19d0 - Browse repository at this point
Copy the full SHA 95b19d0View commit details
Commits on Jan 4, 2021
-
[selectors] Add new :focus-visible tests
These tests check what happens when an active element matches (or not) :focus-visible, and a script causes focus to move elsewhere. Basically these are tests for the next two points of the spec (https://drafts.csswg.org/selectors-4/#the-focus-visible-pseudo): " * If the active element matches :focus-visible, and a script causes focus to move elsewhere, the newly focused element should match :focus-visible. * Conversely, if the active element does not match :focus-visible, and a script causes focus to move elsewhere, the newly focused element should not match :focus-visible. "
1Configuration menu - View commit details
-
Copy full SHA for b855320 - Browse repository at this point
Copy the full SHA b855320View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 8e2098b - Browse repository at this point
Copy the full SHA 8e2098bView commit details -
[selectors] Improve :focus-visible tests
* Now we have one test per element, so we have more detailed PASS/FAIL information. We also check that all test conditions (outline and background colors) are right. * Use more common colors in tests like "green" and "red" instead of "darkgreen" and "tomato". * focus-visible-004.html actually set "appearance: none". So elements that are hidden now and not focusable (radio button and checkbox) are removed. * focus-visible-007.html is not modified as it has more problems (see https://crbug.com/976438).
Configuration menu - View commit details
-
Copy full SHA for 77ffd6e - Browse repository at this point
Copy the full SHA 77ffd6eView commit details -
Fix a css-paint-api/ layout test failure
This CL fixes a failing layout test dynamic-import.html. The problem with it is that all the file name under css-paint-api/ needs to be foo.https.html so that our test infra knows that it should spin up an https server to run that test. The failing test doesn't have the right suffix and that's why. This Cl simply rename the test and it should be good. Bug: 1157960 Change-Id: I3cdad68715eb0289b4a8707fa1d4c8a63421e031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606483 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840031}
Configuration menu - View commit details
-
Copy full SHA for 48a1ecb - Browse repository at this point
Copy the full SHA 48a1ecbView commit details -
[WPT] Move upstream focus-querySelector-in-focus-event-handler.html
This patches converts the js-test.js test into a testharness.js, and move it to WPT upstream repository. BUG=523126 Change-Id: I3f5a6338f38af731d18f547c75bd9fd7274b5ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610084 Reviewed-by: Sergio Villar <svillar@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#840036}
Configuration menu - View commit details
-
Copy full SHA for ecb548a - Browse repository at this point
Copy the full SHA ecb548aView commit details
Commits on Jan 5, 2021
-
[wpt] Fix position-sticky-nested-table.html
wpt/css/css-position/sticky/position-sticky-nested-table.html test was broken. It failed in FF/Safari, and Chrome with TablesNG. https://wpt.fyi/results/css/css-position/sticky/position-sticky-nested-table.html The broken part of the test insterted an absolutely positioned element as a sibling of every element with sticky position. The abspos element is then positioned so that its position matches sticky elements position. I am not sure what this was testing. This does not work for tables, because instertion of abspos sibling to td element creates an anonymous table wrapper. The anonymous wrapper becomes abspos container. This CL removes creation of the abspos element. The test now passes in all browsers. Change-Id: I548afad533040509567ca24265306ace0d28d4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610190 Reviewed-by: David Grogan <dgrogan@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#840049}
Configuration menu - View commit details
-
Copy full SHA for 7bf6d4c - Browse repository at this point
Copy the full SHA 7bf6d4cView commit details -
don't round unspecified image dimensions to integers
Differential Revision: https://phabricator.services.mozilla.com/D100562 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1684567 gecko-commit: b2bde87ec64a27ae2432984cde901bb4e0b9b291 gecko-reviewers: emilio
Configuration menu - View commit details
-
Copy full SHA for 077d53c - Browse repository at this point
Copy the full SHA 077d53cView commit details -
[selectors] Make :focus-visible tests platform independent
For browsers that don't support :focus-visible yet this change will make them to have consistent failure results independently of the focus ring color on the different platforms. Apart from that focus-visible-006.html is modified like we did for the other tests in web-platform-tests#26994.
Configuration menu - View commit details
-
Copy full SHA for 1799ada - Browse repository at this point
Copy the full SHA 1799adaView commit details -
[selectors] Fix typo in the CSS of focus-visible-009.html
It was using #buton ID, instead of #button.
Configuration menu - View commit details
-
Copy full SHA for 3684161 - Browse repository at this point
Copy the full SHA 3684161View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0b4b6b - Browse repository at this point
Copy the full SHA e0b4b6bView commit details -
Port format_json.py to Python 3 (web-platform-tests#27037)
This fixes a WPT lint error with Python 3
Configuration menu - View commit details
-
Copy full SHA for e0ad10b - Browse repository at this point
Copy the full SHA e0ad10bView commit details -
[sandbox] Add WPT tests: inheritance from initiator.
Make sure sandbox flags are properly inherited when the initiator of the navigation isn't the parent. This checks both sandbox flags defined by the frame and by the HTTP response. Bug: 1041376 Change-Id: I3c0b808ef9ec3ebefde40ec7609a36a1f5edaf6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607790 Reviewed-by: Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#840132}
Configuration menu - View commit details
-
Copy full SHA for 1a5e588 - Browse repository at this point
Copy the full SHA 1a5e588View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88cc801 - Browse repository at this point
Copy the full SHA 88cc801View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea99445 - Browse repository at this point
Copy the full SHA ea99445View commit details -
Use SelectionBatcher in SetRangeText
Differential Revision: https://phabricator.services.mozilla.com/D100705 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1682706 gecko-commit: d07e3cf6247a9e889af81001d23665ee8d65ef58 gecko-reviewers: masayuki
Configuration menu - View commit details
-
Copy full SHA for f218a80 - Browse repository at this point
Copy the full SHA f218a80View commit details -
Remove myself from reviewers and PoC (web-platform-tests#27049)
* Remove myself from tools/META.yml * Remove myself from the admin page and add smcgruer@ instead
Configuration menu - View commit details
-
Copy full SHA for 33f8de1 - Browse repository at this point
Copy the full SHA 33f8de1View commit details -
[LayoutNG] Fix incorrect start offset for nested abspos
In some specific cases, the offset of the innermost abspos was off by exactly one fragmentainer block size. This CL fixes the issue. Bug: 1157086 Change-Id: I9ee621e11d7e411de56a8d8c3da1561d2eb1f7e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602442 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#840252}
Configuration menu - View commit details
-
Copy full SHA for d3ce095 - Browse repository at this point
Copy the full SHA d3ce095View commit details -
Handle transition keyframes in composite bg color animation
This CL handles transition keyframes when we composite background color animation. Bug: 1153670 Change-Id: I9252db7f7344472d8fc9f1866d1f5b2a038dd2f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589114 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#840297}
Configuration menu - View commit details
-
Copy full SHA for 348d0d9 - Browse repository at this point
Copy the full SHA 348d0d9View commit details
Commits on Jan 6, 2021
-
Return mouse offset coordinates in SVG relative to the SVG root.
This matches other browsers. Needs a test, if the try server comes back green. Differential Revision: https://phabricator.services.mozilla.com/D100762 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1684973 gecko-commit: acb6c55d8192e22f1203686e56744cf8cea8e110 gecko-reviewers: smaug
Configuration menu - View commit details
-
Copy full SHA for 138a258 - Browse repository at this point
Copy the full SHA 138a258View commit details -
Audio min / pref isize should not depend the controls.
Otherwise the adjustments that the media controls do in response to size changes affect the size itself, which can cause cyclic layout. Differential Revision: https://phabricator.services.mozilla.com/D100722 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1683979 gecko-commit: b6ffa373415664405a767cd30b6681d54fd8f4fb gecko-reviewers: dholbert
Configuration menu - View commit details
-
Copy full SHA for 22d4100 - Browse repository at this point
Copy the full SHA 22d4100View commit details -
Configuration menu - View commit details
-
Copy full SHA for d937841 - Browse repository at this point
Copy the full SHA d937841View commit details -
Fix the typo "ot" in various code-comments (to "to", "of", or "not").
DONTBUILD because this is a comment-only change and hence doesn't affect behavior at all. I ran across this typo in nsPageFrame.cpp, and figured I might as well grep for it and fix it more comprehensively. And while I'm at it, I also fixed some neighboring instances of a duplicated word around a linebreak, in nsXMLContentSerializer.h. Differential Revision: https://phabricator.services.mozilla.com/D100852 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1685231 gecko-commit: 334133676943ec44532d6e885b884af8d762ff95 gecko-reviewers: mccr8
Configuration menu - View commit details
-
Copy full SHA for 9af15d4 - Browse repository at this point
Copy the full SHA 9af15d4View commit details -
Fix CSP embedded enforcement with sandbox directive.
Due to a bug, CSP embedded enforcement was ignoring the whole CSP directive when it contained one using the sandbox directive. This patch trivially fix it. This is intented to be merged into M89 This patch also adds many tests for the documents: 1. initial empty document 2. about-blank 3. about-srcdoc 4. data-url 5. blob-url 6. same-origin 7. cross-origin (1)(2)(3) are failing, because of https://crbug.com/1163174 Bug: 1163108,1163174 Change-Id: I888ab01009ae914809680451beee37c69b12734f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611264 Reviewed-by: Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#840581}
Configuration menu - View commit details
-
Copy full SHA for b7c0a3e - Browse repository at this point
Copy the full SHA b7c0a3eView commit details -
Add command-line flag to turn on debug logging in 'wpt manifest'
Previously there were debug statements in the code, but no way to turn them on outside of modifying the code. This commit removes an old 'setup()' method that appears not to be used, and instead adds a command-line flag (-v/--verbose) to enable debug logs. A few more logs are also added to the flow to help the reader understand what is happening.
Configuration menu - View commit details
-
Copy full SHA for 474afc7 - Browse repository at this point
Copy the full SHA 474afc7View commit details -
'wpt manifest' - cap the multiprocessing factor on Windows
The manifest code previously just used multiprocessing.cpu_count() for its number of processes. This can cause problems on Windows desktops with a high number of cores, due to bugs in cypthon - see https://crbug.com/1160108 and https://bugs.python.org/issue40263. This commit caps the number of cores on Windows to a probably-safe value.
Configuration menu - View commit details
-
Copy full SHA for e04f27b - Browse repository at this point
Copy the full SHA e04f27bView commit details -
Add support for lighter operator in feComposite
Spec: https://www.w3.org/TR/filter-effects-1/#attr-valuedef-operator-lighter Lighter is defined in the compositing & blending spec as equivalent to porter-duff plus, https://www.w3.org/TR/compositing-1/#porterduffcompositingoperators_plus. The 'lighter' composite mode already works in <canvas> (via globalCompositeOperation), and it's the same there. Chrome implemented support in https://bugs.chromium.org/p/chromium/issues/detail?id=439037 Per w3c/svgwg#424 we should expose the new value in webidl and Chrome uses 7 too (https://codereview.chromium.org/779963002/patch/120001/130009) Differential Revision: https://phabricator.services.mozilla.com/D100605 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1518099 gecko-commit: 12325181f43aee1257922717f8ae4d52e4e502d6 gecko-reviewers: jrmuizel, emilio
Configuration menu - View commit details
-
Copy full SHA for 939a0c0 - Browse repository at this point
Copy the full SHA 939a0c0View commit details -
Part 3 - Make flex item work with box-sizing when its aspect-ratio is…
… set from <ratio>. When specifying aspect-ratio: '<ratio>' [1], the size calculations involving the aspect ratio work with the dimensions of the box specified by box-sizing. However, when specifying aspect-ratio: 'auto && <ratio>' [2] the size calculations involving the aspect ratio work with the content box dimensions always. MainSizeFromAspectRatio() doesn't consider box-sizing, so we replace it with AspectRatio::ComputeRatioDependentSize() which considers box-sizing. [1] https://drafts.csswg.org/css-sizing-4/#valdef-aspect-ratio-ratio [2] https://drafts.csswg.org/css-sizing-4/#valdef-aspect-ratio-auto--ratio Differential Revision: https://phabricator.services.mozilla.com/D100371 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1683976 gecko-commit: d2a613ecea6b3eb0b963170739614100b722e1c9 gecko-reviewers: dholbert
Configuration menu - View commit details
-
Copy full SHA for feec993 - Browse repository at this point
Copy the full SHA feec993View commit details -
Part 4 - Reset ReflowInput's mBSizeIsSetByAspectRatio flag if we over…
…ride flex item's block-size. If the flex container overrides a flex item's block-size, we don't want to apply aspect-ratio's automatic content-based minimum sizes [1] in that axis. [1] https://drafts.csswg.org/css-sizing-4/#aspect-ratio-minimum Differential Revision: https://phabricator.services.mozilla.com/D100809 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1683976 gecko-commit: 2ebcdae9c5373aa7af6e7434f1b0236e63b0d8a9 gecko-reviewers: dholbert
Configuration menu - View commit details
-
Copy full SHA for f72bb49 - Browse repository at this point
Copy the full SHA f72bb49View commit details -
Part 2: HTML parser should invoke custom element's callbacks before a…
…ppending child nodes if it is not created for fragment See whatwg/html#4025. Depends on D10226 Differential Revision: https://phabricator.services.mozilla.com/D10228 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1489437 gecko-commit: 7aa96c414add38fc3863ac894a530a6d273d3608 gecko-reviewers: smaug
Configuration menu - View commit details
-
Copy full SHA for 2e422e6 - Browse repository at this point
Copy the full SHA 2e422e6View commit details -
Add test for IntersectionObserver with document as root (web-platform…
…-tests#27064) Added test for IntersectionObserver with document as root If specify {root: document}, the rootBounds should be the root intersection rectangle which is the document's viewport.
Configuration menu - View commit details
-
Copy full SHA for 5a3a1b4 - Browse repository at this point
Copy the full SHA 5a3a1b4View commit details -
[blinkpy] Re-enable a few more tests that were blocked on crbug.com/9…
…97202 Bug: 997202 Change-Id: I670d9134fc8770c58f8688366a16830ba9a6435e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575454 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#840635}
Configuration menu - View commit details
-
Copy full SHA for 8b8c6a9 - Browse repository at this point
Copy the full SHA 8b8c6a9View commit details -
Revert "[blinkpy] Re-enable a few more tests that were blocked on crb…
…ug.com/997202" This reverts commit 3482d6eae9c2168f4eabd4efdc32ed7df0b4992b. Reason for revert: foreign-object-scale-scroll.html failing https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests Original change's description: > [blinkpy] Re-enable a few more tests that were blocked on crbug.com/997202 > > Bug: 997202 > Change-Id: I670d9134fc8770c58f8688366a16830ba9a6435e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575454 > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Kevin Ellis <kevers@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840635} TBR=kevers@chromium.org,smcgruer@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ife0806922968b2f63b83e6ee9edd271cca86c5ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 997202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612272 Reviewed-by: Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#840712}
Configuration menu - View commit details
-
Copy full SHA for c6c2a95 - Browse repository at this point
Copy the full SHA c6c2a95View commit details -
Each pointer should have different pointer id
For testdriver Action API, when we create a pointer, we need to give it a pointer id, we need to give different id for different pointer. We need to save the pointer information based on the pointer id, so we need to give them different pointer id. Bug: 1163370 Change-Id: I6533793151a260ff410d11272c547d2d27b4afa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611948 Reviewed-by: Liviu Tinta <liviutinta@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#840713}
Configuration menu - View commit details
-
Copy full SHA for 825155f - Browse repository at this point
Copy the full SHA 825155fView commit details -
Make invalid 'type' import assertion cause a module to fail to load
Add Modulator::ModuleTypeFromRequest to get the asserted type from a ModuleRequest's list of import assertions, and use it to make module creation fail if an invalid type is asserted. In preparation for subsequent import assertions changes, plumb this module type through GetFetchedModuleScript, where it will be needed for module map lookups since module type will be used in the module map cache key. Add tests for the invalid module type failure, along with tests verifying that JS modules can still load with an empty import assertions clause and an unsupported import assertion. A subsequent change will require the correct type assertion to be present to load a JSON or CSS module, and the existing JSON/CSSS module tests will be updated to reflect the new behavior at that time. Bug: 1132413 Change-Id: I33e3e6ae68b14d6f6c561a58c0e260a7b129d930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603420 Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#840714}
Configuration menu - View commit details
-
Copy full SHA for 6532775 - Browse repository at this point
Copy the full SHA 6532775View commit details -
content-visibility: Don't adjust position of a locked hittest result …
…node. This patch ensures that if we have a hittest result that has a locked node, we don't try to recurse into its subtree. This can happen when we do a PositionWithAffinity check. R=chrishtr@chromium.org Bug: 1162131 Change-Id: I357bd7032c6c2b6c9405bf26c49a36bda22d6a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611453 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#840727}
Configuration menu - View commit details
-
Copy full SHA for 11d344e - Browse repository at this point
Copy the full SHA 11d344eView commit details -
[LayoutNG] Make abspos' fragment encompass the height of its children
In CL:2577757, we allowed fragmentation for abspos positioned using the bottom property and with `height: auto`. There was one remaining issue with the abspos fragment when a child of his had a break-rule - its height was off, giving the impression that it didn't encompass all its children. This CL resolves this issue. The behavior of expanding the height to encompass all children will cause the bottom property to be off from where it was originally intended to be. That's a downside widely discussed offline between Rossen (co-author of the CSS Fragmentation spec), Alison and I, but a solution relatively acceptable to a problem that isn't NP-complete. Gecko seems to do the same as well. Bug: 1156250 Change-Id: Ie67f7aff9a64e7d813f346ad83cd6d4bcd5186e7
Configuration menu - View commit details
-
Copy full SHA for 5cdc2d5 - Browse repository at this point
Copy the full SHA 5cdc2d5View commit details
Commits on Jan 7, 2021
-
Update Safari Technology Preview to 118 (web-platform-tests#27070)
Version as reported by safaridriver --version: Included with Safari Technology Preview (Release 118, 15611.1.9.3.1) Source: https://developer.apple.com/safari/download/ Build: https://dev.azure.com/foolip/safari-technology-preview-updater/_build/results?buildId=2574&view=logs
Configuration menu - View commit details
-
Copy full SHA for 42a5a14 - Browse repository at this point
Copy the full SHA 42a5a14View commit details -
PlzDedicatedWorker: WPT for nested blob URL workers
This CL adds 3 test cases for nested blob URL workers: 1. a blob URL worker (parent) creates a blob URL worker (child) 2. a blob URL worker (parent) creates a worker (child) 3. a worker (parent) creates a blob URL worker (child) When the PlzDedicatedWorker feature is enabled, the first and third tests fail now. Bug: 1017034 Change-Id: I8b2221be3233312cb4f3cf3983215f658a40830d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596490 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#840918}
Configuration menu - View commit details
-
Copy full SHA for 313f99a - Browse repository at this point
Copy the full SHA 313f99aView commit details -
Update performance.measureMemory to the latest spec
The result of a memory measurement now: - includes an empty breakdown entry. - has random order of breakdown entryies. Bug: chromium:1085129 Change-Id: Ie3f338d8274a0276d09f732560ed9797f5c376af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607339 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#841002}
1Configuration menu - View commit details
-
Copy full SHA for 6cda94c - Browse repository at this point
Copy the full SHA 6cda94cView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 6d9af4c - Browse repository at this point
Copy the full SHA 6d9af4cView commit details -
[blinkpy] Add fuzzy bounds to transform-interpolation-rotate-slerp.html
This is a reland of 3482d6ea (reverted in 672e131e), with the SVG changes backed out. Bug: 997202 Change-Id: Id1a63ce0c2fd63b288135de007aab30449508a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611982 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#841089}
Configuration menu - View commit details
-
Copy full SHA for 1ce4208 - Browse repository at this point
Copy the full SHA 1ce4208View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9bef70 - Browse repository at this point
Copy the full SHA b9bef70View commit details -
fix: disable prefetching for TextDocument
The synchronous HTMLDocumentParser mode was incorrectly dispatching preloads for text/plain documents by interpreting their contents as HTML. This CL extends the HTMLDocumentParser's constructor, adds a new enum to disable this behaviour, and a Web Platform Test to show that the unintended prefetching no longer happens. Bug: 1160665 Change-Id: I07902d58e3bc06ce6ecc07c341e997846d6e5a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613008 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#841110}
Configuration menu - View commit details
-
Copy full SHA for f422ffb - Browse repository at this point
Copy the full SHA f422ffbView commit details -
[wpt] Fix css-grid/alignment/grid-alignment-implies-size-change-*.html
From: w3c/csswg-drafts#5713 Basically these tests stretch an image in one axis, and previously tested that the image should lose its aspect-ratio. When stretching in one axis, and when there is no size constraint in the other axis it should respect the aspect-ratio. Change-Id: Ic1374f50b4d561b3c38b94a4f60724f950e6513e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611567 Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#841117}
Configuration menu - View commit details
-
Copy full SHA for 188bf17 - Browse repository at this point
Copy the full SHA 188bf17View commit details -
[resource-timing] Fix negative duration case
Bug: 1157818 Change-Id: Ie5e75ccb239735f3500f8763e4d9255eba2056e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592792 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#841159}
Configuration menu - View commit details
-
Copy full SHA for d9a933a - Browse repository at this point
Copy the full SHA d9a933aView commit details -
This CL has no functional changes. It adds a manual web platform test case which navigates a second after requesting NFC permission. Bug: 1034607 Change-Id: I1174c4d53f192b5b8ff4639d360a39e9170212cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607885 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#841162}
Configuration menu - View commit details
-
Copy full SHA for dc05781 - Browse repository at this point
Copy the full SHA dc05781View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef4efeb - Browse repository at this point
Copy the full SHA ef4efebView commit details
Commits on Jan 8, 2021
-
Rewrite wpt/cookies/http-state/{name,value}-tests.html
For the history books, here's a mapping between the old ported tests and the new tests, where test=N roughly corresponds to a string name or value: in wpt/cookies/name/name.html name0001 through name0016, name0019, name0020 => the for of block with the description "`Name is set as expected for ${name}=test`" name0017 => test=2 name0018 => test=3 name0021 => test=5 name0022 => test=4 name0023 => test=6 name0024 => test=7 name0025 => test=2b name0026. Not ported. This is covered already. A lot. name0028 => test2c name0029 => test with name "Ignore cookie with empty name and empty value" name0030 => test=8 name0031 => test=9 name0032 => "test\"10 name0033 => test=11 in wpt/cookies/value/value.html name0027 => test=15 value0001 => test=16 value0002 => test=17 value0003 => test=18 value0004 => test=19 value0005 => test="20=20" value0006 => test=21 Bug: 1159861 Change-Id: Ica8879a906f13b1464661af8bf1c5f5271a8f54f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615668 Commit-Queue: Mike Taylor <miketaylr@chromium.org> Auto-Submit: Mike Taylor <miketaylr@chromium.org> Reviewed-by: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#841251}
Configuration menu - View commit details
-
Copy full SHA for f6acb66 - Browse repository at this point
Copy the full SHA f6acb66View commit details -
don't call GetDtlsTransport on transceiver if RTCRtpReceiver has been…
… shutdown. Differential Revision: https://phabricator.services.mozilla.com/D100952 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1681025 gecko-commit: 83f3726c41f9c91a9bd8e146a3422e287c4a9354 gecko-reviewers: ng
Configuration menu - View commit details
-
Copy full SHA for 93c1657 - Browse repository at this point
Copy the full SHA 93c1657View commit details -
Implement VideoDecoder.isConfigSupported()
API and motivations described here: w3c/webcodecs#98 Spec PR here: w3c/webcodecs#120 Bug: 1141707 Test: new layout tests Change-Id: I3e53da5961119b4b36ec76666ad1a67cca19b963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612684 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#841376}
Configuration menu - View commit details
-
Copy full SHA for e265ce2 - Browse repository at this point
Copy the full SHA e265ce2View commit details -
Rewrite the computation for inline size for table cols and table cells.
If the inline size is length type, we can just call ToLength(). This patch also adds a wpt to test the table element and its inner table boxes with aspect-ratio. Differential Revision: https://phabricator.services.mozilla.com/D100749 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1685207 gecko-commit: 35348a86557620dca36955218cf101e9b2667fa5 gecko-reviewers: TYLin
Configuration menu - View commit details
-
Copy full SHA for ded2fc6 - Browse repository at this point
Copy the full SHA ded2fc6View commit details -
Bump lxml from 4.5.2 to 4.6.2 in /css
Bumps [lxml](https://github.com/lxml/lxml) from 4.5.2 to 4.6.2. - [Release notes](https://github.com/lxml/lxml/releases) - [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt) - [Commits](lxml/lxml@lxml-4.5.2...lxml-4.6.2) Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for 289878d - Browse repository at this point
Copy the full SHA 289878dView commit details -
[selectors] Fix leaks on :focus-visible tests
The :focus-visible tests were modified recently, but that introduced some leaks that were detected by "WebKit Linux Leak" bot. The tests that were failing are using test_driver.click(). This patch modifies the tests, so they pass without issues when passing --enable-leak-detection to tools/run_web_tests.py in a release build. Bug: 1163172 Change-Id: I9b8b1d0459bf7598fc3330495f3cc3ea95d36dae Cq-Include-Trybots: luci.chromium.try:layout_test_leak_detection,leak_detection_linux Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617818 Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#841432}
Configuration menu - View commit details
-
Copy full SHA for 4eacce5 - Browse repository at this point
Copy the full SHA 4eacce5View commit details -
Configuration menu - View commit details
-
Copy full SHA for f267e1d - Browse repository at this point
Copy the full SHA f267e1dView commit details -
Implement style support for ::spelling-error + ::grammar-error
This implements the style support only, behind a flag, based on the ::target-text counterpart in <https://crrev.com/c/2463563>. The paint code for querying these selectors and paint invalidation, as well as the changes needed to limit the acceptable properties (à la <https://crrev.com/c/2489657>), will be written in another CL. Bug: 1035708 Change-Id: I77e530fbbb78fb20c05325ef75babde91e5ef831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606878 Auto-Submit: Delan Azabani <dazabani@igalia.com> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Manuel Rego <rego@igalia.com> Commit-Queue: Delan Azabani <dazabani@igalia.com> Cr-Commit-Position: refs/heads/master@{#841443}
Configuration menu - View commit details
-
Copy full SHA for 3b2b9ea - Browse repository at this point
Copy the full SHA 3b2b9eaView commit details -
[html] Test unhandled rejection during parse
Co-authored-by: Simon Pieters <zcorpan@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d6c156f - Browse repository at this point
Copy the full SHA d6c156fView commit details -
Keep offset for composite background color animation
At this moment, our implementation only keeps the first and the last keyframes for composite background color animation. This is wrong, for example, we can having multiple keyframes like: 0%: { background-color: red } 10%: { background-color: green} 100% { background-color: blue} This CL fixes the issue. The idea is to keep the offset which we stored in CompositorKeyframeValues. In the above case, the offsets would be [0, 0.1, 1]. Once we have that, here is how we do interpolation. Say that the current progress is 0.4, then we know that it falls in to the range of [0.1, 1], which means we need to interpolate from green to blue. We need to adjust the progress (0.4) based on the offsets. Basically scale [0.1, 1] to [0, 1], then the adjusted progress should be (0.4-0.1) / (1-0.1). Layout tests are added to ensure correctness. Bug: 1153671 Change-Id: I6dffc82b5821fdf418f2b94331f567a239079730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597844 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#841476}
Configuration menu - View commit details
-
Copy full SHA for 89ca0ba - Browse repository at this point
Copy the full SHA 89ca0baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5722cc2 - Browse repository at this point
Copy the full SHA 5722cc2View commit details -
blink: makes contain: paint honor overflow-clip-margin
This gives the same logic as that of 'overflow: clip.' BUG=1159155 TEST=overflow-clip-margin-00[456].html Change-Id: I1396fad5fbf4464daee8d021191797ba7d01856c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596828 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#841477}
Configuration menu - View commit details
-
Copy full SHA for 83fec76 - Browse repository at this point
Copy the full SHA 83fec76View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7e21d0 - Browse repository at this point
Copy the full SHA f7e21d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5873f2d - Browse repository at this point
Copy the full SHA 5873f2dView commit details -
css: Make fetches from inline CSS use the document's URL as referrer
Right now, fetches from inline CSS use the inline CSS's base URL instead of the URL from the context that embeds the inline CSS: for instance, loading a source-site.com page with the following code <base href="https://other-site.com"> <style type=text/css> @import('best-sheet.com') </style> should lead to the best-sheet.com sheet getting fetched with a source-site.com referrer, but it will currently provide an other-site.com referrer. However, if the imported sheet from best-sheet.com makes more nested fetches, those nested requests should use best-sheet.com as the basis for their referrers (as they do currently). This CL updates CSSParserContext's referrer setting logic to roughly do the following: - inline CSS: use the embedding document's URL as the referrer, or, for srcdoc iframes, walk up the frame tree until hitting a non-srcdoc frame - requests from fetched stylesheets: just as currently, use the fetched sheet's URL as the basis for constructing the referrer This seemed like it required refactoring CSSParserContext slightly because there are constructors that take both a Document and a base URL, and it's not obvious from the constructor signature whether the Document or the base URL should be the one that provides the referrer. To resolve this ambiguity, the refactor updates these CSSParserContext constructors to take caller-provided Referrer objects. Change-Id: If5a99d8057dff5e771e821d0e1f605566e28ff1d Fixed: 1158645, 1158010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592447 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#841509}
Configuration menu - View commit details
-
Copy full SHA for 1716db0 - Browse repository at this point
Copy the full SHA 1716db0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95a4789 - Browse repository at this point
Copy the full SHA 95a4789View commit details -
Fixing runner when autorun flag is true
- The tests on complete callback was not being registered
Configuration menu - View commit details
-
Copy full SHA for a351e92 - Browse repository at this point
Copy the full SHA a351e92View commit details -
Don't import fixtures in send_alert_text.py. CLOSED TREE
This appears to be the only consumer of support/authentication.py Differential Revision: https://phabricator.services.mozilla.com/D100250 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1683717 gecko-commit: da6e6f9ba96e18b1d2c081522a17eede44ec4810
Configuration menu - View commit details
-
Copy full SHA for 397e29d - Browse repository at this point
Copy the full SHA 397e29dView commit details -
Migrate WebUSB WPT to Mojo JS modules
Bug: 1004256 Change-Id: Iaaf8e601a7f3e400bd7aff5b60e8586e7adb43a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616519 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#841569}
Configuration menu - View commit details
-
Copy full SHA for 7442d6e - Browse repository at this point
Copy the full SHA 7442d6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c201a5 - Browse repository at this point
Copy the full SHA 5c201a5View commit details -
WebSocketStream: Make backpressure-receive.any.js work again
The web test external/wpt/websockets/stream/tentative/backpressure-receive.any.js started failing on Windows 10 with the switch to Python 3. It appears some additional buffering is happening in the OS. As a workaround, split the large message that is supposed to be delayed by backpressure into 16 parts. BUG=1155106 Change-Id: Ifa2b04e4857f3c537721735cec187f610c053d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613853 Commit-Queue: Domenic Denicola <domenic@chromium.org> Auto-Submit: Adam Rice <ricea@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841571}
Configuration menu - View commit details
-
Copy full SHA for 4f82b31 - Browse repository at this point
Copy the full SHA 4f82b31View commit details -
Expose auto-start-reverse enum value
Per w3c/svgwg#424 we should expose the new value in webidl Differential Revision: https://phabricator.services.mozilla.com/D101089 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1685543 gecko-commit: d7cb06b275cdb59f99aa6ff14e5f6de6ff200723 gecko-reviewers: emilio
Configuration menu - View commit details
-
Copy full SHA for 73deaf7 - Browse repository at this point
Copy the full SHA 73deaf7View commit details -
[css-flex] Apply transferred min/max sizes to svg with no natural sizes
When deriving flex base size of an svg that has an aspect ratio but no natural height or width, we were ignoring min/max sizes specified in the cross-axis direction, even though they should transfer through the aspect ratio and restrict the stretch fit into the available size. Bug: 1162704 Change-Id: If502de43a876e41e6f3784aea089edcd2467ba60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614470 Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#841586}
Configuration menu - View commit details
-
Copy full SHA for d81b71f - Browse repository at this point
Copy the full SHA d81b71fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bf1d81 - Browse repository at this point
Copy the full SHA 7bf1d81View commit details -
Add a lint that anything that uses the reftest-wait script specifies …
…reftest-wait Not having the reftest-wait class on the root is a pretty clear indication of a bug and one that's relatively easy to avoid. Of course this doesn't catch all cases where something happens after load and reftest-wait is required but it at least catches some of the more obvious errors
Configuration menu - View commit details
-
Copy full SHA for 5b4049b - Browse repository at this point
Copy the full SHA 5b4049bView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for c913981 - Browse repository at this point
Copy the full SHA c913981View commit details -
Co-authored-by: Chris Harrelson <chrishtr@gmail.com>
1Configuration menu - View commit details
-
Copy full SHA for 67c3f22 - Browse repository at this point
Copy the full SHA 67c3f22View commit details -
webrtc wpt: fix order of assert
BUG=chromium:1164376 Change-Id: Ic9321b007e652f8d6b0ca40e490645735296317b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616411 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#841614}
Configuration menu - View commit details
-
Copy full SHA for d62bc10 - Browse repository at this point
Copy the full SHA d62bc10View commit details -
Portals: Fix postMessage calls in portals-focus.sub.html resources
Missed fixing these callsites in https://crrev.com/c/2386012. Bug: 1126901 Change-Id: If94b71e0767bb222df3840185e7e00e515592fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616459 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#841619}
1Configuration menu - View commit details
-
Copy full SHA for 42fa444 - Browse repository at this point
Copy the full SHA 42fa444View commit details -
Remove port 554 from the restricted list
Blocking port 554 has known compatibility issues. Unblock it. BUG=1148309,1164418 Change-Id: I51de0e944cdd57cad5f2d5fec145dad7320dfc51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618418 Auto-Submit: Adam Rice <ricea@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#841622}
1Configuration menu - View commit details
-
Copy full SHA for f67cae4 - Browse repository at this point
Copy the full SHA f67cae4View commit details -
Add more :not() serialization tests.
Differential Revision: https://phabricator.services.mozilla.com/D101097 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1685621 gecko-commit: 84e497a940ab8ef75bba3ee485a2b3895e0eeed4 gecko-reviewers: emilio
1Configuration menu - View commit details
-
Copy full SHA for 6e2630e - Browse repository at this point
Copy the full SHA 6e2630eView commit details -
fix: relax performance API checks for prefetch test
This test was flaky because occasionally one or more paint events were included in the Performance API data. The check's been relaxed to remove the intermittent failure. Bug: 901056, 1164166, 1160655 Change-Id: I1fc89ad1cd60bd326b1516ae6b93814f10922b30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618483 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#841696}
1Configuration menu - View commit details
-
Copy full SHA for 2491f9d - Browse repository at this point
Copy the full SHA 2491f9dView commit details
Commits on Jan 9, 2021
-
[LayoutNG] Fix OOF not painted in "tall" multicolumns
In some cases as the one described in https://crbug.com/1151383, non-fragmented OOF are not painted. The computed |offset_from_root| seems to be invalid and this CL fixes it. Bug: 1151383 Change-Id: Ib85440577442782a1f09f704d2224214d4822232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607670 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#841740}
Configuration menu - View commit details
-
Copy full SHA for 1affd04 - Browse repository at this point
Copy the full SHA 1affd04View commit details -
usb: Add a manual test for USB transfer completion order
This manual test attempts to reproduce a case seen in issue 1153647 where parallel calls to transferIn(), recommended for performance, can return data out of order. This test is a starting point in the investigation as it only sends a small amount of data while the original report involves much larger transfers. Bug: 1153647 Change-Id: I4f4b8f5ad502d08ae7c4fb9cc22889047029afc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587950 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: James Hollyer <jameshollyer@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#841773}
1Configuration menu - View commit details
-
Copy full SHA for 28ac8ff - Browse repository at this point
Copy the full SHA 28ac8ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e977a8 - Browse repository at this point
Copy the full SHA 6e977a8View commit details
Commits on Jan 10, 2021
-
Unset drag state when moving focus to text controls
Differential Revision: https://phabricator.services.mozilla.com/D101202 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1665944 gecko-commit: 04e48d1c7a4cc0ff48f4ccbfb34b6a7a3dd41cf2 gecko-reviewers: emilio
1Configuration menu - View commit details
-
Copy full SHA for 3bd64a5 - Browse repository at this point
Copy the full SHA 3bd64a5View commit details -
[wdspec] Fix switch to frame tests for "no such element" error instea…
…d of "stale element reference". Element references are per browsing context. As such elements as found within a frame are not existent in any parent browsing context, and when retrieving these a "no such element" error has to be returned. Depends on D100878 Differential Revision: https://phabricator.services.mozilla.com/D101065 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1684827 gecko-commit: 697e1305e91b8af353916fd09b5e103bb25f28fc gecko-reviewers: webdriver-reviewers, jgraham
1Configuration menu - View commit details
-
Copy full SHA for 8589301 - Browse repository at this point
Copy the full SHA 8589301View commit details
Commits on Jan 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 6c2e813 - Browse repository at this point
Copy the full SHA 6c2e813View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bd1504 - Browse repository at this point
Copy the full SHA 2bd1504View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89e5fec - Browse repository at this point
Copy the full SHA 89e5fecView commit details -
Add test for crbug.com/1162628
Bug: 1162628 Change-Id: I5fae5bd6c0b6d9cfb80f2b65778dfaa6f13291bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620562 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#841993}
Configuration menu - View commit details
-
Copy full SHA for 87ef59e - Browse repository at this point
Copy the full SHA 87ef59eView commit details -
Clean up of OOF multicolumn web tests
Once again, there was a nit we didn't detect in the first out-of-flow-multicol test we ever created and we duplicated it to all tests we created using the original one as a template. This CL fixes it. Change-Id: I7ad19fa9b3eda9205c1ad007b0bfbbe47d31d83d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616972 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#842006}
Configuration menu - View commit details
-
Copy full SHA for 65a260c - Browse repository at this point
Copy the full SHA 65a260cView commit details -
[selectors] Add try/catch for document.querySelector()
:focus-visible is not supported in WebKit yet, add try/catch to focus-in-focus-event-001.html and focus-in-focusin-event-001.html tests, so they work in WebKit too.
Configuration menu - View commit details
-
Copy full SHA for f41f22c - Browse repository at this point
Copy the full SHA f41f22cView commit details -
Add WebDriver tests for computed label/role (web-platform-tests#23793)
* Add WebDriver tests for computed label/role This adds tests for the new Get Computed Role and Get Computed Label endpoints described in w3c/webdriver#1444 * Correct lint issue and add more tests * address comments
Configuration menu - View commit details
-
Copy full SHA for fc208a8 - Browse repository at this point
Copy the full SHA fc208a8View commit details -
Update interfaces/gamepad-extensions.idl (web-platform-tests#27134)
Configuration menu - View commit details
-
Copy full SHA for 27705d1 - Browse repository at this point
Copy the full SHA 27705d1View commit details -
Add a test for :autofill / :-webkit-autofill.
There's no way to trigger autofilling from WPT so this is as much as we can test.
Configuration menu - View commit details
-
Copy full SHA for 6e30c0e - Browse repository at this point
Copy the full SHA 6e30c0eView commit details -
Origin-keyed agent clusters: update WPT for the rename
942aca884980a4dd6c582e3ca1a021769fd18f36 performed the minimal updates to the implementation and tests to shift from "origin isolation" to "origin-keyed agent clusters". This is part of the followup work to fully reflect the rename, in this case focused on the web platform tests. The majority of changes are comment and <title> changes, although some assertion messages are also updated. Note that instead of renaming the top-level directory, we move it under html/, since the the specification is now part of the HTML Standard. Bug: 1158853 Change-Id: I008bb0b5f8c1f943849dfa5fd24cfc99a552f4dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616819 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#842131}
Configuration menu - View commit details
-
Copy full SHA for 21d4331 - Browse repository at this point
Copy the full SHA 21d4331View commit details -
[Import Maps] Add tests for rejecting multiple import maps
According to the spec after WICG/import-maps#242. Bug: 848607 Change-Id: I21e2d494c75ddf9187d2a8d8b63bc59bccd9beb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618680 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#842149}
Configuration menu - View commit details
-
Copy full SHA for 704b551 - Browse repository at this point
Copy the full SHA 704b551View commit details -
Implement AudioDecoder.isConfigSupported()
API and motivations described here: w3c/webcodecs#98 Spec PR here: w3c/webcodecs#120 Bug: 1141707 Test: new layout tests Change-Id: I3a0f3cbc2bb64a86dcefdc454d6b03e72d3f36bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622421 Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#842153}
Configuration menu - View commit details
-
Copy full SHA for 87bcad0 - Browse repository at this point
Copy the full SHA 87bcad0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e01a00c - Browse repository at this point
Copy the full SHA e01a00cView commit details
Commits on Jan 12, 2021
-
fix: attempt to further deflake prefetching test
Test did not properly filter non-resource performance events like paint and longtask. Bug: 901056, 1164166 Change-Id: Ib1b9737b7e720f721e8e25c5275bffe8aab5b7f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623208 Reviewed-by: Mason Freed <masonfreed@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#842234}
Configuration menu - View commit details
-
Copy full SHA for 3918694 - Browse repository at this point
Copy the full SHA 3918694View commit details -
Fix hyphenation for words with leading/trailing punctuation
This patch fixes Minikin hyphenation to hyphenate words with leading and/or trailing punctuation characters, using the same logic as Minikin `WordBreaker`[1]. On Mac, the underlying Core Foundation API handles such cases. This issue is part of the reasons for the last words not being hyphenated <crbug.com/1022415>. [1] https://android.googlesource.com/platform/frameworks/minikin/+/master/libs/minikin/WordBreaker.cpp#270:~:text=WordBreaker%3A%3AwordStart Bug: 815061 Change-Id: I64908bf2000e9586b1cb7f0d28a0d730c6311da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599789 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#842337}
Configuration menu - View commit details
-
Copy full SHA for 4e7079e - Browse repository at this point
Copy the full SHA 4e7079eView commit details -
Hyphenate the last word if only one word in the line
Blink (legacy and NG) and WebKit does not hyphenate the last word in a paragraph, except when it is a single-word paragraph. However, when the containing block is narrow, sometimes authors want a long last word to be hyphenated. This patch changtes the heursitic to allow hyphenation if the line is a single-word line. CSS Text 4 has a property to control this behavior, but no browsers have implemented it yet. Bug: 1022415 Change-Id: Ibd8d8b132e540a142f18efc09a37fed2b207bfdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599567 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#842345}
Configuration menu - View commit details
-
Copy full SHA for f655381 - Browse repository at this point
Copy the full SHA f655381View commit details -
[Scroll Timeline] Clamp overlapping offsets.
Updated procedure that computes scroll timeline progress to accommodate for overlapping offsets. The update is to find last matching interval in the list of offsets. This is analogous to CSS property overrides where last specified property is applied. Bug: 1094014 Change-Id: I7d5c84e58bfea021f931b702d66a87d2d28aaf6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508356 Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by: Kevin Ellis <kevers@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#842367}
Configuration menu - View commit details
-
Copy full SHA for d653680 - Browse repository at this point
Copy the full SHA d653680View commit details -
usb: Expand tests for USB transfer completion order
This change expands the manual test for transferIn() to send much more data and assert that many overlapping transfers will still complete in the correct order. Two changes are necessary to make these tests pass. First, when aborting a transfer on device close the ERROR_REQUEST_ABORTED should be mapped to an AbortError DOMException. Second, transfers should be tracked in a list rather than a map so that iteration order is well defined. Bug: 1153647 Change-Id: I248ce4724e391216783a6873809aca43e4690b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591928 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#842380}
Configuration menu - View commit details
-
Copy full SHA for 80090f6 - Browse repository at this point
Copy the full SHA 80090f6View commit details -
Ensure the break-offset is greater than the non-hangable run end
The ShapeLineBreaker::NextBreakOpportunity function determines the non-hangable run end based on the currently break-offset. This value is, by definition, always smaller than the break-offset. However, if the break-offset value exceed the range_end, we use this as the actual offset. If we have reached this scenario because there is no breaking opportunity to prevent the overflow, then we just call ShapeToEnd and return. Otherwise, we continue processing the text item. In this situation, we must ensure that the new offset is greater than the previously computed non-hangable run end, since it's possible that we end up using it as the final offset, leading to the assert violation described in the bug, since the used break-offset is smaller than the item's end. This CL adds the logic to prevent this situation, clearing the non-hangable run end and computing it again, if necessary, based on the new offset. Bug: 1161793 Change-Id: Ie10ffae3c654aefa626d80abd01bd38e026c9e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604908 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#842461}
Configuration menu - View commit details
-
Copy full SHA for 812cbb3 - Browse repository at this point
Copy the full SHA 812cbb3View commit details -
Mark performance.measureMemory web-platform tests as non-tentative
They were marked as tentative because they were written before the spec. Now the spec is completed and the tests align with the spec. Bug: 1085129 Change-Id: Ieee736a0f54af97e6f0cf2d6bad3c0a7afec2738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620565 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842490}
Configuration menu - View commit details
-
Copy full SHA for a2ae055 - Browse repository at this point
Copy the full SHA a2ae055View commit details -
Add a test for ICE restart when datachannels are open
Bug: chromium:1165692 Change-Id: Ie4ae544d1814384af134080541a60a6778ccbc77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623210 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#842500}
Configuration menu - View commit details
-
Copy full SHA for d408561 - Browse repository at this point
Copy the full SHA d408561View commit details -
Configuration menu - View commit details
-
Copy full SHA for 680c091 - Browse repository at this point
Copy the full SHA 680c091View commit details -
[AspectRatio] Correctly handle intrinsic size for replaced elements
Have to go through the replaced element intrinsic size function for correctness. Bug: 1163850 Change-Id: If08134c1a4d1b70c069459001774bc8ad09a21cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621929 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#842545}
Configuration menu - View commit details
-
Copy full SHA for ddcca80 - Browse repository at this point
Copy the full SHA ddcca80View commit details -
WebKit export of https://bugs.webkit.org/show_bug.cgi?id=220541 (web-…
…platform-tests#27144) Patch was r+ed downstream
Configuration menu - View commit details
-
Copy full SHA for cec2feb - Browse repository at this point
Copy the full SHA cec2febView commit details -
Update README of performance.measureMemory tests
Bug: 1085129 Change-Id: I16ee23ac320300b2e408aca4b8a4873b1f1594ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624674 Auto-Submit: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842621}
Configuration menu - View commit details
-
Copy full SHA for ddaf735 - Browse repository at this point
Copy the full SHA ddaf735View commit details -
Move Bluetooth legacy web tests to internal WPT
This is in preparation for use of JS modules within the tests. They share some library code with external bluetooth WPT, and that code will soon use JS modules. Bug: 1004256 Change-Id: I0817dde4216fa43287cde2788edf5c324cf47fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622578 Commit-Queue: Ken Rockot <rockot@google.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#842683}
Configuration menu - View commit details
-
Copy full SHA for 7627aa0 - Browse repository at this point
Copy the full SHA 7627aa0View commit details -
Migrate WebBluetooth WPT to Mojo JS modules
Bug: 1004256 Change-Id: I3b2b26128d0dce591fefe323a730b827e160bb70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618679 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#842698}
Configuration menu - View commit details
-
Copy full SHA for a695739 - Browse repository at this point
Copy the full SHA a695739View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f4343a - Browse repository at this point
Copy the full SHA 8f4343aView commit details -
[GridNG] Small fix to gap resolution, and abspos container.
Previously we'd just use the intrinsic block-size to resolve gaps, and abs-pos containing rects when we didn't know the block-size upfront. This was slightly incorrect as there might be a min/max size constraint growing or shrinking this final size. This patch moves the call to ComputeBlockSizeForFragment into PlaceItems. As a result of this there are a few small fixes: 1) When we have an indefinite available-size, we resolve the grid-gap against zero. (This was surprising to me grid-gutters-{010,011} was testing this). 2) Abspos "default" size is correctly calculated based on the final block-size (not intrinsic block-size). 3) Resolving gaps against the "resolved" available block-size (not the intrinsic block-size). This correctly respects border/padding as well. Bug: 1045599 Change-Id: I6be819b8eb254fe9e8eaee4d5a9caaa500a75601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624032 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#842748}
Configuration menu - View commit details
-
Copy full SHA for 7021d50 - Browse repository at this point
Copy the full SHA 7021d50View commit details
Commits on Jan 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 35bf0e3 - Browse repository at this point
Copy the full SHA 35bf0e3View commit details -
[css-scroll-snap] Add more tests for initial position in mandatory an…
…d proximity snap modes
Configuration menu - View commit details
-
Copy full SHA for 00d6a95 - Browse repository at this point
Copy the full SHA 00d6a95View commit details -
Add WPT about how CORS behaves in WebBundle subresource loading
It would be better to clarify an expected behavior how CORS behaves for WebBundle subresource loading in the current implementation. Note that - The expected behavior is a tentative decision, which might change in the future. The spec side issue is WICG/webpackage#609. - A |crossorigin| attribute is not supported yet. BUG=1149816 Change-Id: Ic104ec039a07f864b6a60452ff42f2ec09a03c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617167 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#842863}
Configuration menu - View commit details
-
Copy full SHA for a769dc3 - Browse repository at this point
Copy the full SHA a769dc3View commit details -
wptserve: correct sorting in DirectoryHandler
Found this while creating web-platform-tests#27129.
Configuration menu - View commit details
-
Copy full SHA for b4c87a4 - Browse repository at this point
Copy the full SHA b4c87a4View commit details -
Fix generate-test-wbns.sh used in WPT
It looks generate-test-wbns.sh fails with two errors: 1. nested/resource.js is missing 2. cors/resource.json is wrong. It should be cors/resource.cors.json BUG=1082020 Change-Id: I18a87f59784d6c36e050a64567c1ba671af0468a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627209 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#842933}
Configuration menu - View commit details
-
Copy full SHA for c9bb4ac - Browse repository at this point
Copy the full SHA c9bb4acView commit details -
Add a test for backdrop filter underlapping a border
A recent bug [1] showed that in SkiaRenderer, it was possible for a backdrop-filter element to blend pixels from a neighboring (but not underlapping) render pass, due to some clipping issues. This test checks for this situation. The original bug was fixed in [2], but I verified that this test breaks pre-[2] (see patchset 1 of this CL). [1] https://crbug.com/1162743 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2611452 Bug: 1162743 Change-Id: I86d00d9831057ace40476d29848c11ba1b671a82 Fixed: 1165868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625156 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#843000}
Configuration menu - View commit details
-
Copy full SHA for e9e281d - Browse repository at this point
Copy the full SHA e9e281dView commit details
Commits on Jan 14, 2021
-
Add a test for WebDriver capabilities for webSocketUrl
Test establishing a Bidirectional Session capability support
Configuration menu - View commit details
-
Copy full SHA for 23675b4 - Browse repository at this point
Copy the full SHA 23675b4View commit details -
Upgrade pytest to 6.1.1 to be used with pytest-asyncio
There was an error from tools/third_party/pytest/src/_pytest/assertion/rewrite.py about missing _pytest._version module. I commented out the import and hardcoded the version to 6.1.1
Configuration menu - View commit details
-
Copy full SHA for 4b64d94 - Browse repository at this point
Copy the full SHA 4b64d94View commit details -
Add an async style test for connecting to ChromeDriver
Test connecting to ChromeDriver session using websockets and send a message in async/await style
Configuration menu - View commit details
-
Copy full SHA for 0d1de57 - Browse repository at this point
Copy the full SHA 0d1de57View commit details -
Add BidiSession class and tests using modified session fixture
1. Added a BidiSession class in webdriver client that will preset capability for websocket connection. Created async versions of start and end for the class to handle establishing and closing websocket connection. 2. Modify session fixture to take an extra boolean argument "bidi" for creating bidi session. Change the fixture to async and use await when dealing with bidi session start/end. 3. Set event loop scope to session(assuming it would reuse the same event loop for all tests) to avoid event loop is closed error when closing websocket connection. 4. Added tests for different bidi/classic session creation scenario and tested connect/send/close.
Configuration menu - View commit details
-
Copy full SHA for 4bec81f - Browse repository at this point
Copy the full SHA 4bec81fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ccf080 - Browse repository at this point
Copy the full SHA 7ccf080View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6ab5a5 - Browse repository at this point
Copy the full SHA c6ab5a5View commit details -
Squashed 'tools/third_party/pytest/' content from commit 0ad20b533f
git-subtree-dir: tools/third_party/pytest git-subtree-split: 0ad20b533ffc52ced7bb1a03fba664615e90c093
Configuration menu - View commit details
-
Copy full SHA for f06515d - Browse repository at this point
Copy the full SHA f06515dView commit details -
Merge commit 'f06515d59e61faa4a28d3c4580d7fb304d38533d' as 'tools/thi…
…rd_party/pytest'
Configuration menu - View commit details
-
Copy full SHA for c60d2ad - Browse repository at this point
Copy the full SHA c60d2adView commit details -
Configuration menu - View commit details
-
Copy full SHA for d647645 - Browse repository at this point
Copy the full SHA d647645View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77313d8 - Browse repository at this point
Copy the full SHA 77313d8View commit details -
Squashed 'tools/third_party/pluggy/' content from commit b1b07a3096
git-subtree-dir: tools/third_party/pluggy git-subtree-split: b1b07a309653a42a5311810f71d0addd09a4ec81
Configuration menu - View commit details
-
Copy full SHA for 180db02 - Browse repository at this point
Copy the full SHA 180db02View commit details -
Merge commit '180db02d1406240a4c5be1916ec58567f068a83d' as 'tools/thi…
…rd_party/pluggy'
Configuration menu - View commit details
-
Copy full SHA for ea1843d - Browse repository at this point
Copy the full SHA ea1843dView commit details -
Squashed 'tools/third_party/iniconfig/' content from commit 4e20f6bcde
git-subtree-dir: tools/third_party/iniconfig git-subtree-split: 4e20f6bcdef72a2ffef1f811a4540778da60733b
Configuration menu - View commit details
-
Copy full SHA for 6e4fcb2 - Browse repository at this point
Copy the full SHA 6e4fcb2View commit details -
Merge commit '6e4fcb2923422dde9a0ac33a89e942d6352d723f' as 'tools/thi…
…rd_party/iniconfig'
Configuration menu - View commit details
-
Copy full SHA for 8aa7f1a - Browse repository at this point
Copy the full SHA 8aa7f1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c8ee237 - Browse repository at this point
Copy the full SHA c8ee237View commit details -
Squashed 'tools/third_party/websockets/' content from commit 139085fe26
git-subtree-dir: tools/third_party/websockets git-subtree-split: 139085fe2624192a5a6c72b1e5db211dcec6ced1
Configuration menu - View commit details
-
Copy full SHA for 0702b1f - Browse repository at this point
Copy the full SHA 0702b1fView commit details -
Merge commit '0702b1f153d0ae713eda24203f943b79f65b22cb' as 'tools/thi…
…rd_party/websockets'
Configuration menu - View commit details
-
Copy full SHA for 517995e - Browse repository at this point
Copy the full SHA 517995eView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc27953 - Browse repository at this point
Copy the full SHA bc27953View commit details