HTML: attribute selectors with case-insensitive values #43709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given https://bugs.webkit.org/show_bug.cgi?id=265719 this needs some coverage.
Ms2ger
approved these changes
Dec 18, 2023
|
Oh, and:
|
|
Feel free to either add those to this PR or file a followup issue |
webkit-commit-queue
pushed a commit
to annevk/WebKit
that referenced
this pull request
Dec 18, 2023
https://bugs.webkit.org/show_bug.cgi?id=265719 rdar://119432066 Reviewed by Tim Nguyen. Add the missing attribute. New tests are upstreamed here: web-platform-tests/wpt#43709 * LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/case-sensitivity/values.window-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/case-sensitivity/values.window.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/case-sensitivity/values.window.js: Added. (forEach.attributeName.forEach): * LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/case-sensitivity/w3c-import.log: Added. * Source/WebCore/html/HTMLDocument.cpp: (WebCore::HTMLDocument::isCaseSensitiveAttribute): Canonical link: https://commits.webkit.org/272219@main
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given https://bugs.webkit.org/show_bug.cgi?id=265719 this needs some coverage.