Skip to content

Conversation

@CodingItWrong
Copy link
Contributor

This PR makes some buttons in the app more accessible, by marking them as buttons for the sake of accessibility, and by providing text labels for them. The specific use case I'm working with is iOS Voice Control, which lets you tap items on the screen based on their name.

Voice Control provides a names overlay to make it easy to visualize what elements have which names. Before this PR the overlay shows:

image

Note that:

  • Most icon buttons don't have a label
  • Days of the month and the year dropdown aren't indicated as buttons at all

After this PR, the overlay shows:

image

Note that I haven't added accessibility to all components in the app, just the ones I have experience with from the app I'm using RN Paper in.

Thanks for the great library!

@RichardLindhout
Copy link
Member

This is amazing!! I will accept this if it uses the /src/translations so it'll work across other languages too, could you add this?

@CodingItWrong
Copy link
Contributor Author

Will do! I should have time in the morning.

@CodingItWrong
Copy link
Contributor Author

@RichardLindhout OK, updated to use the translations API, and added values for US and GB English. As I don't know the other two languages, how should we proceed? TS won't build the app without those values. (I was able to test out the build locally by temporarily deleting those other language files.)

@RichardLindhout RichardLindhout merged commit 5f197d9 into web-ridge:master Nov 13, 2021
@RichardLindhout
Copy link
Member

Released! Thanks a lot!

@RichardLindhout
Copy link
Member

@RichardLindhout OK, updated to use the translations API, and added values for US and GB English. As I don't know the other two languages, how should we proceed? TS won't build the app without those values. (I was able to test out the build locally by temporarily deleting those other language files.)

Haha, thanks, I'm doing Google Translate for the Polish version since I don't know the language

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants