fix: update input label for pt locale #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey Brandon, can you back this up by some external source on wikipedia it says for Portugal: https://en.wikipedia.org/wiki/Date_format_by_country
|
Contributor
Author
|
If you look on the "Date" wikipedia entry in Portuguese you can see they list the date format as AAAA-MM-DD: https://pt.wikipedia.org/wiki/Data |
Member
|
Thanks! Will try to release a new version next week with this fix :) |
Contributor
Author
|
Great! Thanks! |
Contributor
Author
|
@RichardLindhout Any updates on when this will be released? My team would like to include this change in our next release. |
Member
|
I forgot about it, thanks for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! In Portuguese they use
AAAAinstead ofYYYYfor dates. This PR updates the inputFormat to useAAAAwhen the Portuguese locale is selected.