Update time picker to material 3 specs. #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iM-GeeKy
changed the title
RichardLindhout
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RichardLindhout I think this is ready to look at, but please check it out. I think it's headed in the right direction.
Motivation
Our library supports Material 3, but lacks the proper specs for the Time Picker according to MD3 documentation. This pull request is created to address the initial upgrades for only the Time picker. It's not perfect, but this can serve as the baseline. @RichardLindhout I'll leave the Date Picker for you :). It seems more involved and might cause us to have separate pickers for between version 2 and 3. I'd be glad to discuss a plan of attack on this.
Screenshots
Findings
https://user-images.githubusercontent.com/7604441/209482428-2d85e96e-b9ea-4c16-9e41-03abf88fb50b.mov