Date input props #229
Merged
Date input props #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
DatePickerInputdoes not give the flexibility to roll out your own validation (ex. if a user selected date of birth is older than 18 years) which could result in twohelperTexterrors being shown under theDatePickerInput.This PR introduces a few new props
hideValidationErrors,hasError, andonValidationError, etc in order to provide the ability to ingest the internal validation errors from the component, hide the components error styles, and give the developer the option of rolling out there own validation.The developer docs are updated as well to have all the new props along with some other missing props.