PresentationStyle #311
Merged
PresentationStyle #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pageSheet
Added the prop for presentationStyle also removed the warning of transparent if presentationStyle === 'pageSheet'
Member
|
Looks good! Can you update it with the right prettier? Seems like some things are different ( |
Used the right prettier and removed the ; from the code.
Contributor
Author
|
I just used the right prettier in this commit. Kindly, accept the pull request. @RichardLindhout |
Collaborator
|
@RichardLindhout and @SharfMohiuddin I think we should also add this new prop to the documentation (Date Picker), so it is visible to others who might want to use this in the future. |
Contributor
Author
|
I agree with you. @iM-GeeKy |
Contributor
Author
|
@RichardLindhout kindly accept the pull request. Thanks! |
Collaborator
Would you mind updating the docs as part of this pull request? I'll merge it afterward. |
Contributor
Author
|
sure @iM-GeeKy |
Collaborator
|
@SharfMohiuddin Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pageSheet