Skip to content

chore: fix require cycle warning #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2023
Merged

chore: fix require cycle warning #335

merged 1 commit into from
Sep 17, 2023

Conversation

@iM-GeeKy
Copy link
Collaborator

@iM-GeeKy iM-GeeKy commented Sep 17, 2023 •
edited
Loading

SoyDiego
SoyDiego approved these changes Sep 17, 2023
View reviewed changes
Copy link
Contributor

@SoyDiego SoyDiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me, tested in Android and works perfectly! 🚀
Good work @iM-GeeKy, was very annoying that warning.

@SoyDiego
Copy link
Contributor

SoyDiego commented Sep 17, 2023

The PR is not linked with the issue. Maybe for the mode "task list".
So If you merge will not be close automatically.

@iM-GeeKy iM-GeeKy merged commit 57b5e50 into master Sep 17, 2023
@iM-GeeKy iM-GeeKy deleted the fix-require-recycle branch September 17, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RichardLindhout RichardLindhout Awaiting requested review from RichardLindhout

1 more reviewer

@SoyDiego SoyDiego SoyDiego approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

On Init, show a Warning "Require cycle"

3 participants

@iM-GeeKy @SoyDiego