-
Notifications
You must be signed in to change notification settings - Fork 195
testing the disabling #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing the disabling #64
Conversation
|
This is useful! I'd like to have this feature! |
|
Thanks for your PR but I think it should always be editable if it's inside the validRange |
Can you describe why you want to disable it? |
|
There are a few bugs that I have noticed with editing. I would also like the option of disabling input. Please see the attached vide: datePickerBug.mov |
|
@davehenriksen2711 we need to fix issues like this indeed! Note that on real devices the software keyboard will show only numbers. But I'd rather want the users to be able to change the date and fix the issues which is why the input would need to be disabled. |
The app I'm working with have a new specification that requires the field is not visible. I don't want to use another library since I like a lot this one |
|
@airam666 maybe describe to them you're following the Material Design guidelines and it's not technically easy to remove it https://material.io/components/date-pickers#usage. I think they'll understand it since I think it's a good feature a user will still be able to have keyboard input. I understand your use-case but I rather follow only the guidelines since if we go another route I have more work on other features too. I hated the react-native-paper standpoint to only follow the guidelines very much but now I think it's a good idea. |
|
Thanks Richard, that's a good point about real devices only having numbers for input. The issue in the video is also happening for the web though. |
|
Yeah will fix when I work on the library the next time!
|
|
I decided I want this! But the library has changed a bit is somebody able to resolve conflicts? |
|
Closed in favor of #256 |
DIsabling a field in datapickermodal