Skip to content

Conversation

@airam666
Copy link

DIsabling a field in datapickermodal

@lmichailian
Copy link

This is useful! I'd like to have this feature!

@RichardLindhout RichardLindhout added the question Further information is requested label Apr 6, 2021
@RichardLindhout
Copy link
Member

Thanks for your PR but I think it should always be editable if it's inside the validRange

@RichardLindhout
Copy link
Member

@imi

This is useful! I'd like to have this feature!

Can you describe why you want to disable it?

@davehenriksen2711
Copy link

There are a few bugs that I have noticed with editing. I would also like the option of disabling input. Please see the attached vide:

datePickerBug.mov

@RichardLindhout
Copy link
Member

@davehenriksen2711 we need to fix issues like this indeed! Note that on real devices the software keyboard will show only numbers. But I'd rather want the users to be able to change the date and fix the issues which is why the input would need to be disabled.

@airam666
Copy link
Author

airam666 commented Apr 8, 2021

@imi

This is useful! I'd like to have this feature!

Can you describe why you want to disable it?

The app I'm working with have a new specification that requires the field is not visible. I don't want to use another library since I like a lot this one

@RichardLindhout
Copy link
Member

@airam666 maybe describe to them you're following the Material Design guidelines and it's not technically easy to remove it https://material.io/components/date-pickers#usage.

I think they'll understand it since I think it's a good feature a user will still be able to have keyboard input. I understand your use-case but I rather follow only the guidelines since if we go another route I have more work on other features too. I hated the react-native-paper standpoint to only follow the guidelines very much but now I think it's a good idea.

@davehenriksen2711
Copy link

davehenriksen2711 commented Apr 8, 2021

Thanks Richard, that's a good point about real devices only having numbers for input. The issue in the video is also happening for the web though.

@RichardLindhout
Copy link
Member

RichardLindhout commented Apr 8, 2021 via email

@RichardLindhout
Copy link
Member

I decided I want this! But the library has changed a bit is somebody able to resolve conflicts?

@iM-GeeKy
Copy link
Collaborator

Closed in favor of #256

@iM-GeeKy iM-GeeKy closed this Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs works question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants