Question: Missing iss checker?

[haroldmodesto]

Q	A
Bug report?	no
Feature request?	no
BC Break report?	no
RFC? / Specification	no
Version	1.2.3

I'm new to this framework and to JWT in general. I was looking for an issuer checker under Component/Checker and did not find any. I was about to write one when I found IssuerChecker class as one of the stubs under tests. I may be missing something fundamental to the library - why doesn't the framework "officially" include an "iss" claims checker?

[Spomky]

Hi,

I think you refer to this stub.
You are right, there is no ISS checker anymore in the v1.x of the checker component.
I removed some checkers because I was not happy with their architecture (copy/paste code). Generic checkers will be added in the next major release that will be issued by the end of the year.
You still can create a dedicated checker. In the example hereafter, the checker will reject issuer claim that is not in the list:

<?php

namespace Acme\Checker;

use Jose\Component\Checker\ClaimChecker;

final class IssuerChecker implements ClaimChecker
{
    private const CLAIM_NAME = 'iss';

    private $issuers;

    /**
     * @param string[] $issuers
     */
    public function __construct(array $issuers)
    {
        $this->issuers = $issuers;
    }

    public function checkClaim($value)
    {
        if (!\is_string($value)) {
            throw new InvalidClaimException('Invalid value.', self::CLAIM_NAME, $value);
        }
        if (!\in_array($value, $this->issuers, true)) {
            throw new InvalidClaimException('Unknown issuer.', self::CLAIM_NAME, $value);
        }
    }

    public function supportedClaim(): string
    {
        return self::CLAIM_NAME;
    }
}

[haroldmodesto]

@Spomky Thanks that clears it up and thank you for all your work on this framework.

[Spomky]

Closing as integrated in the v2.0 to be released by the end of the month.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.