Skip to content

Conversation

@herndlm
Copy link
Contributor

@herndlm herndlm commented Jan 26, 2021

Claim and header checker managers were incorrectly defined as JWSVerifierService which made it impossible to lint the container via bin/console lint:container.

Claim and header checker managers were incorrectly defined as `JWSVerifierService` which made it impossible to lint the container via `bin/console lint:container`.
@herndlm
Copy link
Contributor Author

herndlm commented Jan 26, 2021

I noticed the errors from a custom service that gets a ClaimCheckerManager injected but they are also coming from inside the bundle if I disable my service:

$ bin/console lint:container
 [ERROR] Invalid definition for service "Jose\Bundle\JoseFramework\DataCollector\CheckerCollector": argument 2
         of "Jose\Bundle\JoseFramework\DataCollector\CheckerCollector::addHeaderCheckerManager()" accepts
         "Jose\Bundle\JoseFramework\Services\HeaderCheckerManager", "Jose\Component\Signature\JWSVerifier"
         passed.

Please be aware that I never wrote a bundle or modified the Container internals, so I'm not sure if this is the correct fix.

@Spomky Spomky merged commit 04d348a into web-token:v2.2 Jan 29, 2021
@Spomky
Copy link
Member

Spomky commented Jan 29, 2021

Hi @monojp,

Many thanks for this PR. It looks good to me.
I will tag ASAP.

BR.

@herndlm herndlm deleted the fix_checker_di_definitions branch February 1, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants