This repository was archived by the owner on Jul 16, 2025. It is now read-only.
Merged
Conversation
added 2 commits
February 8, 2024 14:13
Contributor
Website preview 🔗✨ |
vasco-santos
approved these changes
Feb 8, 2024
vasco-santos
left a comment
vasco-santos
left a comment
There was a problem hiding this comment.
oh cool! thanks, I started looking into it yesterday but did not do much progress as I did not touch console before.
LGTM
travis
approved these changes
Feb 8, 2024
Contributor
travis
left a comment
travis
left a comment
There was a problem hiding this comment.
Would be great to unify SWR key generation, but can ship without that if you're tryna get this out the door asap!
| await client?.remove(root, { shards: true }) | ||
| setRemoveConfirmModalOpen(false) | ||
| // ensure list data is fresh | ||
| mutate(`/space/${spaceDID}/uploads?cursor=&pre=`) |
Contributor
There was a problem hiding this comment.
would be nice to pull this key string generation out to a function that can also be used here: https://github.com/web3-storage/console/blob/main/src/app/space/%5Bdid%5D/page.tsx#L25
alanshaw
pushed a commit
that referenced
this pull request
Feb 9, 2024
🤖 I have created a release *beep* *boop* --- ## [1.5.0](w3console-v1.4.1...w3console-v1.5.0) (2024-02-09) ### Features * remove upload ([#90](#90)) ([92aaabf](92aaabf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
fforbeck
pushed a commit
to storacha/upload-service
that referenced
this pull request
Feb 5, 2025
🤖 I have created a release *beep* *boop* --- ## [1.5.0](storacha/console@w3console-v1.4.1...w3console-v1.5.0) (2024-02-09) ### Features * remove upload ([#90](storacha/console#90)) ([92aaabf](storacha/console@92aaabf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a remove button and confirmation modal to make sure folks really want to remove the upload.
Button on upload info page
Button hover state (red so you know it is dangerous)
Confirmation modal
resolves storacha/w3up#1298