fix: abort race contestants when all fulfill#48
Merged
vasco-santos merged 1 commit intomainfrom Oct 11, 2022
Merged
Conversation
vasco-santos
force-pushed
the
fix/abort-race-contestants-when-all-fulfill
branch
2 times, most recently
from
c2778a2 to
a6930eb
Compare
vasco-santos
force-pushed
the
fix/abort-race-contestants-when-all-fulfill
branch
from
a6930eb to
5ce70d5
Compare
alanshaw
approved these changes
Oct 10, 2022
This was referenced Oct 11, 2022
This was referenced Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
ipfs-gateway-racelib to support an option to abort specific race contestants on demand. When consumers opt in fornoAbortRequestsOnWinnerthey can abort when needed.In
edge-gateway, we rely onipfs-gateway-racewithnoAbortRequestsOnWinnerbecause we track TTFB of each gateway. However, as soon as fetch promise of gateway requests is fulfilled we can abort the non winner contestants to not get extra bandwidth consumed.Closes #11