This repository was archived by the owner on Mar 5, 2025. It is now read-only.
  
  
  - 
                Notifications
    
You must be signed in to change notification settings  - Fork 5.1k
 
update formatsubscriptionResult type #6369
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    jdevcs
  
              
              approved these changes
              
                  
                    Aug 18, 2023 
                  
              
              
            
            
| 
           If its merged before 21st Aug evening, we can make it part of 4.1.1  | 
    
          Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total 
 View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged 
  | 
    
              
                    avkos
  
              
              approved these changes
              
                  
                    Aug 18, 2023 
                  
              
              
            
            
          Deploying with  
 | 
    
| Latest commit: | 
48b1f3b
 | 
| Status: | ✅ Deploy successful! | 
| Preview URL: | https://0268849a.web3-js-docs.pages.dev | 
| Branch Preview URL: | https://6368.web3-js-docs.pages.dev | 
          Codecov Report
 Additional details and impacted files@@           Coverage Diff           @@
##              4.x    #6369   +/-   ##
=======================================
  Coverage   89.11%   89.11%           
=======================================
  Files         199      199           
  Lines        7723     7723           
  Branches     2128     2128           
=======================================
  Hits         6882     6882           
  Misses        841      841           
 Flags with carried forward coverage won't be shown. Click here to find out more. 
  | 
    
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
#6368 Fix the typings issue truffle team is facing for v4 migration
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.