Fixes #656 usage strings to be in sync with command parsing#660
Merged
snazha-blkio merged 2 commits intoLFDT-web3j:release/4.0from Oct 26, 2018
Merged
Fixes #656 usage strings to be in sync with command parsing#660snazha-blkio merged 2 commits intoLFDT-web3j:release/4.0from
snazha-blkio merged 2 commits intoLFDT-web3j:release/4.0from
Conversation
Contributor
Author
|
Is the travis fail a fluke? Running the same failing command locally passes. I'm gonna try retriggering the checks. |
Codecov Report
@@ Coverage Diff @@
## master #660 +/- ##
=========================================
Coverage 77.13% 77.13%
Complexity 1793 1793
=========================================
Files 239 239
Lines 6664 6664
Branches 996 996
=========================================
Hits 5140 5140
Misses 1272 1272
Partials 252 252
Continue to review full report at Codecov.
|
snazha-blkio
approved these changes
Oct 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage string and actual usage were not in sync. I think changing the usage to reflect actual usage is the only way to go for it to stay backwards compatible.