Skip to content
This repository was archived by the owner on Sep 7, 2022. It is now read-only.

#22 - Ensure event handlers aren't duplicated #23

Merged
merged 3 commits into from
Jul 1, 2016
Merged

#22 - Ensure event handlers aren't duplicated #23

merged 3 commits into from
Jul 1, 2016

Conversation

@treshugart
Copy link
Contributor

@treshugart treshugart commented Jul 1, 2016

Fixes #22.

@joscha
Copy link
Member

joscha commented Jul 1, 2016

LGTM

@treshugart
Copy link
Contributor Author

treshugart commented Jul 1, 2016

Do we want to enable the use of ontest and onTest? DOM events are case sensitive. Properties are case sensitive. But if you use an attribute name in HTML, it's not case sensitive. Not sure what to do here. No strong opinions either way right now.

@joscha
Copy link
Member

joscha commented Jul 1, 2016 •
edited
Loading

I think to align with <a onclick=""> vs. <a onClick=""> it should be case insensitive.

@joscha joscha merged commit 621f01c into master Jul 1, 2016
@joscha joscha deleted the 22 branch July 1, 2016 04:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@treshugart @joscha @jpnelson