Fix clients base uri according Azure Cloud #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfairat15
changed the title
Member
|
Thanks, looks good 👍 |
mick03131
approved these changes
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
#1
What does it fix?
It allows azure-metrics-exporter work with correct ResourceManagerEndpoint, according Azure Cloud (China, US, Public).
Any other comments?
Not sure, that app should get azure-ad-resource-url from parameters.
I thought, that AzureEnvironment.ResourceManagerEndpoint is enough, but if we look at https://github.com/Azure/go-autorest/blob/master/autorest/azure/auth/auth.go#L111 - we may see, that
s.Values[Resource]use value fromAZURE_AD_RESOURCEinstead of AzureEnvironment.ResourceManagerEndpoint