Skip to content

Conversation

@t3mi
Copy link
Contributor

@t3mi t3mi commented Jul 26, 2023

What this PR does / why we need it

This PR adds support the the vertical pod autoscaler so users do not have to care about the resource usage of the azure-resourcemanager-exporter and let the vertical pod autoscaler to do its job.
Also, fixes invalid value ref to existing config map key and whitespaces in labels.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [azure-metrics-exporter])

@t3mi
Copy link
Contributor Author

t3mi commented Aug 29, 2023

@mblaschke any chance you could review opened PRs?

@mblaschke
Copy link
Member

@t3mi

i would remove (.Capabilities.APIVersions.Has "autoscaling.k8s.io/v1") from the if clause. this would lead to a failed deployment if this apiversion is not available instead of just ignoring VPA.
this would give the user direct feedback that something is wrong.
what do you think?

Signed-off-by: t3mi <t3mi@users.noreply.github.com>
@t3mi
Copy link
Contributor Author

t3mi commented Sep 6, 2023

@mblaschke capability check was removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants