Enable support for Fully Qualified Repository URL without combining registry and repository #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Introduced an if statement in the
_helper.tplfiles to check if theregistryvariable is empty, in order to allow Fully Qualified Repository URLs as the "image" specifier that is used in the Helm deployment that Kubernetes fetches when it needs an image.Applies the following commits:
Which issue this PR fixes
Special notes for your reviewer
Please decline if you disagree with this PR. Let us have a discussion in the issue for a better solution.
And please let me know if the Chart Version bumping is the wrong kind of bump. I didn't know if it requires a patch or a minor version upgrade.
Checklist
[azure-metrics-exporter])This applies to all charts