fix: represent export correctly in types #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current types are incorrect because this plugin is exported using
module.exportswhich is not equivalent toexport default; while TypeScript handles this under the hood for native TS files (which is why those don't error), attempting to use this module withrequirein JS files checked by TypeScript will result in an error:This is because TypeScript expects such modules to be exporting a
defaultproperty that should be used in CommonJS, so instead it wants us to do{ default: RemoveEmptyScriptsPlugin }:This property does not actually exist at runtime though:
Instead, the correct way to type a
module.exportsbased export is to useexport =, and then to use anamespaceto export additional types and interfaces (as there can only be one top-level export).