Skip to content

Conversation

@wswebcreation
Copy link
Member

This PR fixes #1038. There was an incorrect determination of ignore areas due to incorrect interpretation of width/height

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2025

🦋 Changeset detected

Latest commit: 068323d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@wdio/image-comparison-core Patch
@wdio/visual-service Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wswebcreation wswebcreation self-assigned this Nov 17, 2025
@wswebcreation wswebcreation added the bug Something isn't working label Nov 17, 2025
@BosseKarat
Copy link
Contributor

I tested this locally by manipulating node_modules in v.8.0.4 and it is working as expected. Nice work and thank you ❤️

@wswebcreation
Copy link
Member Author

I tested this locally by manipulating node_modules in v.8.0.4 and it is working as expected. Nice work and thank you ❤️

Hi @BosseKarat
thanks! I will only release this in the latest version. I still need to dive into the other issue regarding the cropping. That one was also a blocker for you to migrate, or not?

@BosseKarat
Copy link
Contributor

Yes @wswebcreation, that is correct. This is the one #1000

Let me know if you want me test any changes before merge 👍

@wswebcreation wswebcreation merged commit 2c109b3 into main Nov 21, 2025
11 checks passed
@wswebcreation wswebcreation deleted the ws/fix-1038-incorrect-ignore-regions branch November 21, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

checkScreen does not register any changes on iOS using Browserstack

3 participants