Skip to content
This repository was archived by the owner on Dec 18, 2019. It is now read-only.

Conversation

@benurb
Copy link
Contributor

@benurb benurb commented Sep 9, 2015

Hi,

there is a little problem with the check for the cropping parameters. It was doing a falsy check instead of a proper numeric check, so that the following config did not work, because of 0 for x/y resolving to false:

{
  name: "name",
  x: 0,
  y: 0,
  width: 100,
  height: 100
}

This PR fixes the check 😄

Best regards,
Ben

@christian-bromann
Copy link
Contributor

Sorry for the delay. This looks good! Thanks

christian-bromann added a commit that referenced this pull request Oct 28, 2015
Replace falsy check of coordinates with proper numeric check
@christian-bromann christian-bromann merged commit e1f734e into webdriverio-boneyard:master Oct 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants