This repository was archived by the owner on Dec 18, 2019. It is now read-only.
Scrollbars on first screenshot #118
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benurb
force-pushed
the
pr/fix-first-screenshot-scrollbars
branch
from
b312c6e to
0d7ca13
Compare
… first screenshot, though they should be already hidden
benurb
force-pushed
the
pr/fix-first-screenshot-scrollbars
branch
from
0d7ca13 to
8c547b0
Compare
Contributor
|
I am not sure if this is the ultimate solution. It's basically just a bigger delay. |
Contributor
Author
|
Me neither, but for me it fixed the visible scrollbars. But adding a delay in ms is a valid solution, too. But imho something should be done. |
Contributor
Agree, I will see to find a native Selenium solution. Thanks for opening the PR though 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
As mentioned in #79 sometimes the first screenshot is taken too early and the scrollbars are still visible. In contrast to the solution proposed there I tried to solve it without a pause of <insert arbitrary number here> ms. Splitting the script in three different execute blocks (that naturally take longer to execute than one) fixed the problem for me, but maybe a pause is still needed.
Best regards,
Ben