This repository was archived by the owner on Dec 18, 2019. It is now read-only.
Prevent webdrivercss() from modifying an array passed to it. #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@brettle thanks for contributing! I don't quite understand the fix as the test passed in the last build and on my local machine. |
Contributor
Author
|
The commit has both the test and the fix. To see the test fail, revert the change I made to lib/workflow.js. Note that this has nothing to do with the issue I recently reported with one of the existing tests failing. |
Contributor
|
ohh now I see the issue here. You've passed in a variable and that variable changed after executing the webdrivercss command. Should have read the issue title before looking at the change 😄 |
Contributor
Author
|
This PR now includes a simple workaround for the unrelated failing test mentioned in issue #76. Sorry for combining PRs, but its probably easier to merge both in one shot anyway. |
Contributor
|
Awesome, thanks! |
christian-bromann
added a commit
that referenced
this pull request
May 18, 2015
Prevent webdrivercss() from modifying an array passed to it.
Contributor
|
published with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit includes a new test which failed before the fix. Let me know if you need more info.