Skip to content

fix(meeting): updated sdkcomponentadapter version to add password flow#219

Merged
Kesari3008 merged 1 commit intowebex:masterfrom
Kesari3008:SPARK-505398
May 8, 2024
Merged

fix(meeting): updated sdkcomponentadapter version to add password flow#219
Kesari3008 merged 1 commit intowebex:masterfrom
Kesari3008:SPARK-505398

Conversation

@Kesari3008
Copy link
Copy Markdown
Contributor

@Kesari3008 Kesari3008 commented May 8, 2024

Upgrading sdk-component-adpater repo version to the latest to include the password flow for the guest user.

Testcase 1: The guest joins the meeting by entering the password.
Testcase 2: The guest joins the meeting as host by entering the host key

Screen.Recording.2024-05-08.at.3.08.41.PM.mp4

Testcase 3: Host joins with host access token without a password prompt.
https://github.com/webex/widgets/assets/65543166/135cf872-4e0c-43e1-a0ec-3317c45ac45d

Copy link
Copy Markdown
Contributor

@sreenara sreenara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Any reason why the Video is disabled while joining the meeting? The console seemed to show some error to get the stream.

@Kesari3008
Copy link
Copy Markdown
Contributor Author

Changes look good. Any reason why the Video is disabled while joining the meeting? The console seemed to show some error to get the stream.

@sreenara I disabled the video that's why

@Kesari3008 Kesari3008 merged commit f944c4d into webex:master May 8, 2024
arun3528 pushed a commit that referenced this pull request May 8, 2024
## [1.26.2](v1.26.1...v1.26.2) (2024-05-08)

### Bug Fixes

* **meeting:** fixing build error ([#220](#220)) ([2a0f6e5](2a0f6e5))
* **meeting:** updated sdkcomponentadapter version to add password flow ([#219](#219)) ([f944c4d](f944c4d))
@arun3528
Copy link
Copy Markdown

arun3528 commented May 8, 2024

🎉 This PR is included in version 1.26.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Copy Markdown
Contributor

@Neeraj-swarnkar Neeraj-swarnkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment

Comment thread package.json
"@babel/plugin-proposal-export-default-from",
"@babel/plugin-proposal-nullish-coalescing-operator",
"@babel/plugin-proposal-object-rest-spread",
"@babel/plugin-transform-object-rest-spread",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just see PR is merged, @Kesari3008 , One question, why is this change in line -
This "@babel/plugin-proposal-object-rest-spread", is replaced by "@babel/plugin-transform-object-rest-spread",

@Neeraj-swarnkar
Copy link
Copy Markdown
Contributor

@Kesari3008, Also I don't see package.lock file change ? Did you do npm install after upgrade.

@Kesari3008 Kesari3008 deleted the SPARK-505398 branch November 6, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants