Skip to content

fix(cc-task): visibility toggle for conference feature #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rsarika merged 5 commits into from
Nov 13, 2025
Merged

fix(cc-task): visibility toggle for conference feature #553

rsarika merged 5 commits into from
Nov 13, 2025

Conversation

@rsarika
Copy link
Contributor

@rsarika rsarika commented Nov 13, 2025 •
edited by akulakum
Loading

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

hiding conference feaeture(buttons) based on feature flag prop passed to call control and call control cad widgets.

by making the following changes

Added additional condition in task-utils to honour the prop passed as part of call control and call control cad widgets.

Added checkbox in sample app to quickly toggle the feature.

Screenshot 2025-11-13 at 8 08 56 PM

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done with the amplify link
    < ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - cursor)
    • Github Copilot
    • Other - cursor
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document

@rsarika rsarika added the validated Indicates that the PR is ready for actions label Nov 13, 2025
@aws-amplify-us-east-2
Copy link

aws-amplify-us-east-2 bot commented Nov 13, 2025

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-553.d1b38q61t1z947.amplifyapp.com

adhmenon
adhmenon approved these changes Nov 13, 2025
View reviewed changes
Copy link
Contributor

@adhmenon adhmenon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ensure we test it properly.

mkesavan13
mkesavan13 requested changes Nov 13, 2025
View reviewed changes
Copy link
Contributor

@mkesavan13 mkesavan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few tiny changes in the review comments:

Also are we giving a separate toggle for EP-DN in Consult? We did that for address book search, I believe. Let's consider that too and add toggles for whatever we have provided so far in Call Control under the Call Control widget box itself.

Also let's make the PR title reflect which component we are making changes in.

fix(cc-task): visibility toggle for conference and ep-dn

@rsarika
Copy link
Contributor Author

rsarika commented Nov 13, 2025

EP-DN in Consult it will be not shown in the consult popover at all if the epdn toggle(given by adhwaith) is off

@akulakum akulakum requested a review from mkesavan13 November 13, 2025 14:47
mkesavan13
mkesavan13 approved these changes Nov 13, 2025
View reviewed changes
Copy link
Contributor

@mkesavan13 mkesavan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor comments. It will be good to cleanup the commits before merging.

If we are reusing the branch, we should have did a merge with ccwidgets branch first before making new commits.

Approving.

packages/contact-center/store/package.json Outdated
"webpack-merge": "6.0.1"
}
}
}
Copy link
Contributor

@mkesavan13 mkesavan13 Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this file from commit

Copy link
Contributor

@akulakum akulakum Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

packages/contact-center/task/src/CallControl/index.tsx
}}
>
<CallControlInternal {...props} multiPartyConferenceEnabled={props.multiPartyConferenceEnabled ?? true} />
<CallControlInternal {...props} conferenceEnabled={props.conferenceEnabled ?? true} />
Copy link
Contributor

@mkesavan13 mkesavan13 Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this extra step? Why can't props itself handle it? I see we anyway read from props for props.conferenceEnabled

Copy link
Contributor Author

@rsarika rsarika Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if nothing passed we need to make sure by default enable it. If We can do it better way we can handle it in next PR.

packages/contact-center/task/src/CallControlCAD/index.tsx
}}
>
<CallControlCADInternal {...props} multiPartyConferenceEnabled={props.multiPartyConferenceEnabled ?? true} />
<CallControlCADInternal {...props} conferenceEnabled={props.conferenceEnabled ?? true} />
Copy link
Contributor

@mkesavan13 mkesavan13 Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as above

Copy link
Contributor Author

@rsarika rsarika Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if nothing passed we need to make sure by default enable it. If We can do it better way we can handle it in next PR.

@rsarika rsarika force-pushed the conference branch 2 times, most recently from c2e5a35 to 91329c9 Compare November 13, 2025 15:19
rsarika and others added 5 commits November 13, 2025 20:54
@rsarika
fix: changed or added feature flag to disable conference feature
27075a0
@akulakum @rsarika
fix(multy-party-conference): add-mcp-visibility-check
0fc7bbb
@akulakum @rsarika
fix(multy-party-conference): address-review-comments
0f8f8aa
@akulakum @rsarika
fix(multy-party-conference): address-review-comments
63b58f5
@akulakum @rsarika
Squashed commit of the following:
dc8ca0d 
commit c1d6c29
Merge: 34a270e 2ff45cd
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Wed Nov 12 19:19:08 2025 +0530

    Merge branch 'ccwidgets' of https://github.com/webex/widgets into conference

commit 34a270e
Author: “Akula <akulakum@cisco.com>
Date:   Tue Nov 11 10:44:49 2025 +0530

    fix(multy-party-conference): update-cc-sdk-version

commit a37922a
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Mon Nov 10 11:48:47 2025 +0530

    fix: visibilities of mute

commit 405aedf
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Fri Nov 7 10:12:21 2025 +0530

    fix: consult completed condition

commit 811ca91
Merge: eed5212 6a2358c
Author: rsarika <95286093+rsarika@users.noreply.github.com>
Date:   Thu Nov 6 20:58:22 2025 +0530

    Merge branch 'ccwidgets' into conference

commit eed5212
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Thu Nov 6 17:56:45 2025 +0530

    fix: simplified button click methods

commit 65ba13c
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Thu Nov 6 14:49:22 2025 +0530

    fix: interaction type from cc sdk

commit 2320263
Merge: 822627a 84752ae
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Thu Nov 6 10:56:30 2025 +0530

    Merge branch 'conference' of https://github.com/rsarika/widgets into conference

commit 822627a
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Thu Nov 6 10:55:04 2025 +0530

    fix: addressed comments

commit 84752ae
Author: “Akula <akulakum@cisco.com>
Date:   Thu Nov 6 10:50:03 2025 +0530

    fix(multy-party-conference): address-review-comments-for-uts

commit 36846ef
Author: “Akula <akulakum@cisco.com>
Date:   Thu Nov 6 09:03:45 2025 +0530

    fix(multy-party-conference): address-review-comments

commit 478db9a
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Wed Nov 5 20:39:53 2025 +0530

    fix: addressed comments

commit f69531f
Author: “Akula <akulakum@cisco.com>
Date:   Wed Nov 5 19:24:17 2025 +0530

    fix(multy-party-conference): address-style-related-issues

commit 40e7ae6
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Wed Nov 5 18:22:36 2025 +0530

    fix: updated switch to main call

commit c96ccbf
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Wed Nov 5 13:12:01 2025 +0530

    fix: fixed customer left scenarios

commit 80ffada
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Wed Nov 5 10:14:41 2025 +0530

    fix: customerLeft

commit 0c53e6c
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Tue Nov 4 19:22:16 2025 +0530

    fix: fixed consult visibility

commit 3728f89
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Tue Nov 4 17:28:52 2025 +0530

    fix: update exit conference visibility

commit 5a89b9f
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Tue Nov 4 17:09:54 2025 +0530

    fix: updated end button visibility

commit 6e254c1
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Tue Nov 4 17:07:42 2025 +0530

    fix: updated consult button and end button visibilities

commit 404ee6f
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Tue Nov 4 12:57:18 2025 +0530

    fix: checkbox fixed

commit 758e94d
Merge: 418036f d199953
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Tue Nov 4 11:52:58 2025 +0530

    Merge branch 'ccwidgets' of https://github.com/webex/widgets into conference

commit 418036f
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Tue Nov 4 11:22:42 2025 +0530

    fix: added new task:merged event for epdn support

commit 4eedaec
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Mon Nov 3 21:17:10 2025 +0530

    fix: added more condition for EPDN being consulted

commit 975e4c9
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Fri Oct 31 21:07:52 2025 +0530

    fix: visibility of consult screen when wrapupRequired

commit 8f1746b
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Fri Oct 31 13:12:34 2025 +0530

    fix: missing visibilities

commit 8cde7c4
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Fri Oct 31 10:49:39 2025 +0530

    fix: addressed comments

commit ae70a3c
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Fri Oct 31 10:35:07 2025 +0530

    fix: removed commented code and added documentation

commit 374917e
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Fri Oct 31 10:20:26 2025 +0530

    feat: added switch to main/consult call feature

commit 0e9a006
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Wed Oct 29 15:26:37 2025 +0530

    fix: max participants

commit f0fcfc7
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Tue Oct 28 17:15:17 2025 +0530

    fix: visibility of consult when others in consult

commit 47ecc38
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Tue Oct 28 15:49:21 2025 +0530

    fix: fixed hold timer and refactored consult buttons visibilities

commit 5d6318a
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Tue Oct 28 12:00:18 2025 +0530

    fix: removed unused store variables

commit f7bb451
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Tue Oct 28 08:43:32 2025 +0530

    fix: refactored to constants

commit d6399d0
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Tue Oct 28 07:41:52 2025 +0530

    fix: refactored to remove isConsultButtonDisabled

commit 8126c32
Merge: a71c589 bad5a63
Author: rsarika <95286093+rsarika@users.noreply.github.com>
Date:   Mon Oct 27 20:52:52 2025 +0530

    Merge branch 'ccwidgets' into conference

commit a71c589
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Mon Oct 27 20:51:42 2025 +0530

    fix: refactor visibility to avoid flags incase of consult

commit cdee558
Author: “Akula <akulakum@cisco.com>
Date:   Thu Oct 23 13:31:37 2025 +0530

    fix(tests): add missing outdialANIId property to agentConfig in test mocks

commit 6c59bc1
Author: “Akula <akulakum@cisco.com>
Date:   Thu Oct 23 13:26:15 2025 +0530

    fix(multy-party-conference): update-cc-sdk-version

commit 110b801
Merge: c54f9ec aa4bcfc
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Wed Oct 22 21:19:56 2025 +0530

    Merge branch 'conference'

commit c54f9ec
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Tue Oct 21 13:26:46 2025 +0530

    fix: max count

commit ab389ac
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Tue Oct 21 12:02:30 2025 +0530

    fix: task selection

commit ef5804e
Author: “Akula <akulakum@cisco.com>
Date:   Fri Oct 17 15:54:08 2025 +0530

    fix(multy-party-conference): fix-conference-uts

commit 1800b06
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Fri Oct 17 11:33:32 2025 +0530

    feat: added allow particpnats to talk checkbox

commit f2e9df6
Merge: bb545b3 572450a
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Thu Oct 16 10:26:33 2025 +0530

    Merge branch 'ccwidgets' of https://github.com/webex/widgets into conference

commit bb545b3
Author: “Akula <akulakum@cisco.com>
Date:   Wed Oct 15 18:12:32 2025 +0530

    fix(multy-party-conference): added-uts-for-conference-functionality

commit b65d9b9
Merge: 842726b 3f7237d
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Tue Oct 14 16:11:14 2025 +0530

    Merge branch 'ccwidgets' of https://github.com/webex/widgets into conference

commit 842726b
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Tue Oct 14 15:59:18 2025 +0530

    fix: multiPartyConferenceEnabled added

commit a26e605
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Tue Oct 14 15:57:13 2025 +0530

    fix: added multiPartyConferenceEnabled feature flag as prop

commit 82a79be
Author: “Akula <akulakum@cisco.com>
Date:   Fri Oct 10 16:33:59 2025 +0530

    fix(multy-party-conference): fix-failed-uts

commit 306264c
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Thu Oct 9 19:14:50 2025 +0530

    feat: multi conference updated tests

commit a0fd964
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Thu Oct 9 18:54:24 2025 +0530

    feat: multi conference fixed participants list logic

commit 19f1902
Merge: f7a6a01 7992ef0
Author: “Akula <akulakum@cisco.com>
Date:   Thu Oct 9 17:19:48 2025 +0530

    Merge branch 'conference' of github.com:rsarika/widgets into conference

commit f7a6a01
Author: “Akula <akulakum@cisco.com>
Date:   Thu Oct 9 17:19:15 2025 +0530

    fix(multy-party-conference): fix-participants design

commit 7992ef0
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Thu Oct 9 16:52:24 2025 +0530

    feat: multi conference fixed types

commit 73a5b54
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Thu Oct 9 11:33:05 2025 +0530

    feat: multi conference tests

commit 03b80c5
Author: Ravi Chandra Sekhar Sarika <rsarika@cisco.com>
Date:   Thu Oct 9 10:00:07 2025 +0530

    feat: multi conference
fix(multy-party-conference): address-review-comments
@rsarika rsarika changed the title fix(cc-widgets): Enable or disable Conference feature based on prop fix(cc-task): visibility toggle for conference and ep-dn Nov 13, 2025
@rsarika rsarika changed the title fix(cc-task): visibility toggle for conference and ep-dn fix(cc-task): visibility toggle for conference feature Nov 13, 2025
@rsarika rsarika merged commit ab5fd64 into webex:ccwidgets Nov 13, 2025
8 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 13, 2025
@semantic-release-bot
chore(release): 1.28.0-ccwidgets.124 [skip ci]
9294d8f 
# [1.28.0-ccwidgets.124](v1.28.0-ccwidgets.123...v1.28.0-ccwidgets.124) (2025-11-13)

### Bug Fixes

* **cc-task:** visibility toggle for conference feature ([#553](#553)) ([ab5fd64](ab5fd64))
@mkesavan13
Copy link
Contributor

mkesavan13 commented Nov 13, 2025

🎉 This PR is included in version 1.28.0-ccwidgets.124 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akulakum akulakum akulakum left review comments

@mkesavan13 mkesavan13 mkesavan13 approved these changes

@adhmenon adhmenon adhmenon approved these changes

Assignees

No one assigned

Labels

released on @ccwidgets validated Indicates that the PR is ready for actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rsarika @mkesavan13 @akulakum @adhmenon