[GLIB] Do not resolve '-apple-system' font to default system font#63791
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 023c1c8) Details |
Collaborator
|
EWS run on previous version of this PR (hash 2c0b892) Details |
Collaborator
|
EWS run on previous version of this PR (hash 71eb78f) Details |
Collaborator
|
EWS run on previous version of this PR (hash fd60533) Details |
Collaborator
|
EWS run on current version of this PR (hash 1ba4363) Details |
carlosgcampos
approved these changes
Apr 30, 2026
https://bugs.webkit.org/show_bug.cgi?id=209727 Reviewed by Carlos Garcia Campos. Follow-up to 312073@main. After 312073@main, Apple system fonts such as '-apple-system' or '-apple-system-font' are resolved to the default system's font in GLIB ports. That change produced a regression in how pages using '-apple-system' fonts are rendered in GLIB ports since, in case the font could not be resolved, any potential fallback font stated in a page's stylesheet wouldn't get applied. Thus, this new patch restores the previous behaviour in which '-apple-system' fonts do not map to the default system's font in GLIB ports. In fact, now '-apple-system' fonts exit early to save time trying to resolve that font. * LayoutTests/platform/glib/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt: * LayoutTests/platform/glib/fast/text/system-font-features-expected.html: * LayoutTests/platform/glib/fast/text/system-font-legacy-name-expected.txt: Added. * Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp: (WebCore::isSystemUIFamilyFont): (WebCore::isUnsupportedFamilyFont): (WebCore::FontCache::createFontPlatformData): Canonical link: https://commits.webkit.org/312351@main
1ba4363 to
73d4d6d
Compare
Collaborator
|
Committed 312351@main (73d4d6d): https://commits.webkit.org/312351@main Reviewed commits have been landed. Closing PR #63791 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
73d4d6d
1ba4363
🛠 win🧪 win-tests🧪 ios-wk2-wpt🧪 api-mac-debug🧪 api-ios🧪 mac-AS-debug-wk2🛠 watch-sim